Subject: pkg/15510: chat/irssi needs USE_NCURSES, it segfaults when linked to -lcurses
To: None <gnats-bugs@gnats.netbsd.org>
From: Lubomir Sedlacik <salo@Xtrmntr.org>
List: netbsd-bugs
Date: 02/06/2002 20:52:49
>Number:         15510
>Category:       pkg
>Synopsis:       chat/irssi needs USE_NCURSES, it segfaults when linked to -lcurses
>Confidential:   no
>Severity:       critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Feb 06 11:54:00 PST 2002
>Closed-Date:
>Last-Modified:
>Originator:     Lubomir Sedlacik
>Release:        NetBSD 1.5ZA
>Organization:
>Environment:
>Description:

Irssi (chat/irssi) package needs USE_NCURSES=yes otherwise it segfaults when
linked to -lcurses (at least on my -current systems). i added backup download
sites as well and removed unneccessary patches (who wants to patch
Makefile.am??).

>How-To-Repeat:
>Fix:

PLEASE, REMOVE patches/patch-ac AND patches/patch-ad
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^


Index: Makefile
===================================================================
RCS file: /cvsroot/pkgsrc/chat/irssi/Makefile,v
retrieving revision 1.5
diff -u -u -r1.5 Makefile
--- Makefile	2001/11/29 01:12:26	1.5
+++ Makefile	2002/02/06 19:38:07
@@ -1,22 +1,27 @@
 # $NetBSD: Makefile,v 1.5 2001/11/29 01:12:26 hubertf Exp $
 
 DISTNAME=		irssi-0.7.98.4
-PKGREVISION=		1
+PKGREVISION=		2
 CATEGORIES=		chat
-MASTER_SITES=		http://www.irssi.org/files/
+MASTER_SITES=		http://www.irssi.org/files/ \
+			http://fi.irssi.org/files/ \
+			http://no.irssi.org/files/ \
+			http://de.irssi.org/files/ \
+			http://us.irssi.org/files/
 
 MAINTAINER=		mutru@nallukka.net
 HOMEPAGE=		http://www.irssi.org/
 COMMENT=                Secure and modular IRC client with text mode user interface
 
 GNU_CONFIGURE=		yes
-
-CONFIGURE_ARGS+=	--enable-perl=no \
-			--with-ncurses=${BUILDLINK_DIR}
 USE_BUILDLINK_ONLY=	yes
 USE_CONFIG_WRAPPER=	yes
+USE_NCURSES=		yes
 
 .include "../../mk/bsd.prefs.mk"
+
+CONFIGURE_ARGS+=	--enable-perl=no
+CONFIGURE_ARGS+=	--with-ncurses=${BUILDLINK_DIR}
 
 .if defined(USE_INET6) && ${USE_INET6} == "YES"
 CONFIGURE_ARGS+=	--enable-ipv6
Index: distinfo
===================================================================
RCS file: /cvsroot/pkgsrc/chat/irssi/distinfo,v
retrieving revision 1.2
diff -u -u -r1.2 distinfo
--- distinfo	2001/11/27 16:10:10	1.2
+++ distinfo	2002/02/06 19:38:07
@@ -2,7 +2,5 @@
 
 SHA1 (irssi-0.7.98.4.tar.gz) = 6d3b6524c3f69c88de02edc2d8efd9c958d8e293
 Size (irssi-0.7.98.4.tar.gz) = 852619 bytes
-SHA1 (patch-aa) = 57d67436f1928b34f1cafec4c91583ae2e82beb2
-SHA1 (patch-ab) = 32f124bccb9096ef98cc217cdc9e0da138bd4565
-SHA1 (patch-ac) = 7029603478a06615426e9b933f41c5a0a3fa181a
-SHA1 (patch-ad) = 59f4746ef23e116c4d2a6ab15c391d6e98ec6fd4
+SHA1 (patch-aa) = 32f124bccb9096ef98cc217cdc9e0da138bd4565
+SHA1 (patch-ab) = 59f4746ef23e116c4d2a6ab15c391d6e98ec6fd4
Index: patches/patch-aa
===================================================================
RCS file: /cvsroot/pkgsrc/chat/irssi/patches/patch-aa,v
retrieving revision 1.1.1.1
diff -u -u -r1.1.1.1 patch-aa
--- patch-aa	2001/09/16 16:14:09	1.1.1.1
+++ patch-aa	2002/02/06 19:38:07
@@ -1,10 +1,13 @@
 $NetBSD: patch-aa,v 1.1.1.1 2001/09/16 16:14:09 hubertf Exp $
 
---- docs/Makefile.am.orig	Sat Sep 15 22:20:22 2001
-+++ docs/Makefile.am	Sat Sep 15 22:20:29 2001
-@@ -1,4 +1,4 @@
+--- docs/Makefile.in.orig	Sat Sep 15 22:25:00 2001
++++ docs/Makefile.in	Sat Sep 15 22:25:40 2001
+@@ -116,7 +116,7 @@
+ perlpath = @perlpath@
+ sedpath = @sedpath@
+ 
 -docdir = $(prefix)/doc/irssi
 +docdir = $(prefix)/share/doc/irssi
+ 
+ doc_DATA =  	botnet.txt 	design.txt 	formats.txt 	manual.txt 	perl.txt 	signals.txt 	special_vars.txt 	startup-HOWTO.html 	startup-HOWTO.txt
  
- doc_DATA = \
- 	botnet.txt \
Index: patches/patch-ab
===================================================================
RCS file: /cvsroot/pkgsrc/chat/irssi/patches/patch-ab,v
retrieving revision 1.1.1.1
diff -u -u -r1.1.1.1 patch-ab
--- patch-ab	2001/09/16 16:14:09	1.1.1.1
+++ patch-ab	2002/02/06 19:38:07
@@ -1,13 +1,12 @@
 $NetBSD: patch-ab,v 1.1.1.1 2001/09/16 16:14:09 hubertf Exp $
 
---- docs/Makefile.in.orig	Sat Sep 15 22:25:00 2001
-+++ docs/Makefile.in	Sat Sep 15 22:25:40 2001
-@@ -116,7 +116,7 @@
- perlpath = @perlpath@
- sedpath = @sedpath@
+--- src/fe-text/Makefile.in.orig	Sun Mar 18 14:34:53 2001
++++ src/fe-text/Makefile.in
+@@ -121,7 +121,6 @@
+ INCLUDES =  	$(GLIB_CFLAGS) 	-I$(top_srcdir)/src 	-I$(top_srcdir)/src/core/ 	-I$(top_srcdir)/src/irc/core/ 	-I$(top_srcdir)/src/fe-common/core/ 	-I$(top_srcdir)/src/fe-common/irc/ 	$(CURSES_INCLUDEDIR) 	-DLOCALEDIR=\""$(datadir)/locale"\"
  
--docdir = $(prefix)/doc/irssi
-+docdir = $(prefix)/share/doc/irssi
  
- doc_DATA =  	botnet.txt 	design.txt 	formats.txt 	manual.txt 	perl.txt 	signals.txt 	special_vars.txt 	startup-HOWTO.html 	startup-HOWTO.txt
+-irssi_DEPENDENCIES = @COMMON_LIBS@
+ 
+ irssi_LDADD =  	@COMMON_LIBS@ 	@PERL_LINK_LIBS@ 	@PERL_FE_LINK_LIBS@ 	$(PROG_LIBS)         $(CURSES_LIBS)
  
>Release-Note:
>Audit-Trail:
>Unformatted: