>Number:         14426
>Category:       pkg
>Synopsis:       audio/gqmpeg mangles id3 tags in windows-1251 encoding
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Nov 01 16:02:00 PST 2001
>Closed-Date:
>Last-Modified:
>Originator:     Sergey Svishchev
>Release:        1.5Y
>Organization:
>Environment:
>Description:
Makefile of audio/gqmpeg has (since rev. x.x)

CONFIGURE_ARGS+= --enable-japanese

in it.  The code which is enabled by this option is meant to aid Japanese users
to view mp3 tags in different Japanese encodings; however, when applied to tags in 
windows-1251 encoding (common for Russian mp3s), it mangles them and the result
is unpleasant.  Also note that to view these tags at all, the user has to put
something like this in her ~/.gqmpeg/gtkrc:

style "gtk-default-ru-1251" {
       font = "-*-serene-medium-r-normal-*-*-120-*-*-*-*-windows-1251"
}
class "GtkWidget" style "gtk-default-ru-1251"

This is a workaround until someone writes the code to convert tags using libiconv,
since, normally, fonts in koi8-r enconding are used as default.

>How-To-Repeat:
Get yourself lots of mp3 files with id3 tags in windows-1251 encoding, try to
pick and choose one for listening.  Get annoyed.

>Fix:
Index: audio/gqmpeg/Makefile
--- Makefile  2001/10/24 22:10:44 1.44
+++ Makefile  2001/11/01 22:21:26
@@ -19,7 +19,9 @@
 USE_X11BASE=   YES
 GNU_CONFIGURE=   YES
 CONFIGURE_ARGS+= --without-included-gettext
+.if !defined(GQMPEG_NO_JAPANESE)
 CONFIGURE_ARGS+= --enable-japanese
+.endif
 CONFIGURE_ENV+=    PKGLOCALEDIR="${PKGLOCALEDIR}"
 
 # in case gnome isn't installed, we need to create the directories

>Release-Note:
>Audit-Trail:
>Unformatted: