>Number:         14364
>Category:       port-i386
>Synopsis:       recent NACPI additions to mainbus.c breaks non-PCI kernels (including some required for "make release")
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    port-i386-maintainer
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Oct 26 09:09:01 PDT 2001
>Closed-Date:
>Last-Modified:
>Originator:     Rob Windsor
>Release:        NetBSD 1.5Y 20011025
>Organization:
Nose-Pickers Anonymous
>Environment:
System: NetBSD grinder 1.5Y NetBSD 1.5Y (GRINDER) #9: Thu Oct 25 19:50:50 CDT 2001 windsor@grinder:/usr/src/sys/arch/i386/compile/GRINDER i386
sys/arch/i386/i386/mainbus.c:
     $NetBSD: mainbus.c,v 1.34 2001/10/24 15:53:04 soren Exp $
Architecture: i386
Machine: i386
>Description:
	all non-PCI kernels listed in sys/arch/i386/conf blow up with:

ld -Ttext c0100000 -e start -T ../../../../arch/i386/conf/kern.ldscript -X -o netbsd ${SYSTEM_OBJ} vers.o
mainbus.o: In function `mainbus_attach':
mainbus.o(.text+0x26): undefined reference to `pci_mode_detect'
mainbus.o(.text+0x2b): undefined reference to `pci_mode'
*** Error code 1

Stop.
make: stopped in /usr/src/sys/arch/i386/compile/GENERIC_PS2TINY


>How-To-Repeat:
	build GENERIC_PS2TINY or GENERIC_TINY or INSTALL_TINY or INSTALL_PS2
>Fix:
	apply following patch:

--- sys/arch/i386/i386/mainbus.c.FCS	Fri Oct 26 11:02:49 2001
+++ sys/arch/i386/i386/mainbus.c	Fri Oct 26 11:04:00 2001
@@ -140,10 +140,12 @@
 
 	printf("\n");
 
+#if NPCI > 0
 	/*
 	 * ACPI needs to be able to access PCI configuration space.
 	 */
 	pci_mode = pci_mode_detect();
+#endif
 
 #if NACPI > 0
 	if (acpi_probe()) {

>Release-Note:
>Audit-Trail:
>Unformatted: