Subject: admin/14351: key_timehandler() prototyped incorrectly in
To: None <gnats-bugs@gnats.netbsd.org>
From: None <seanb&qnx.com@netbsd.org>
List: netbsd-bugs
Date: 10/25/2001 06:43:31
>Number:         14351
>Category:       admin
>Synopsis:       key_timehandler() prototyped incorrectly in <netkey/key.h>
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    netbsd-admin
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Oct 25 06:44:00 PDT 2001
>Closed-Date:
>Last-Modified:
>Originator:     Sean Boudreau
>Release:        1-5 patch002
>Organization:
QNX Software Systems
>Environment:
NetBSD fili 1.5.1 NetBSD 1.5.1 (ker.xtang) #2: Mon Jul 30 09:33:07 EDT 2001
>Description:
Since key_timehandler() is passed to callout_reset(), it should
probably be prototyped correctly:
extern void key_timehandler __P((void *));

This also removes the need to cast away the warning in netkey/key.c:
callout_reset(&key_timehandler_ch, hz,
    key_timehandler, (void *)0);
>How-To-Repeat:
Depending on compiler, there may not be one.  By why leave
it to chance :).
>Fix:
See description.
>Release-Note:
>Audit-Trail:
>Unformatted: