Subject: pkg/13265: www/navigator3 forces install into X11BASE, even with xpkgwedge
To: None <gnats-bugs@gnats.netbsd.org>
From: None <John.P.Darrow@wheaton.edu>
List: netbsd-bugs
Date: 06/20/2001 17:48:37
>Number:         13265
>Category:       pkg
>Synopsis:       www/navigator3 forces install into X11BASE, even with xpkgwedge
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Jun 20 15:47:00 PDT 2001
>Closed-Date:
>Last-Modified:
>Originator:     John Darrow
>Release:        NetBSD/i386 1.5.1_BETA2 20010602; pkgsrc 20010607
>Organization:
Computing Services, Wheaton College, Wheaton, IL
>Environment:
NetBSD rebekah.wheaton.edu 1.5.1_BETA2 NetBSD 1.5.1_BETA2 (REBEKAH) #0: Thu Jun  7 06:19:18 CDT 2001     jdarrow@michal.wheaton.edu:/var/src/sys/arch/i386/compile/REBEKAH i386


>Description:
Package www/navigator3 tries to force itself to install in X11BASE, even if 
xpkgwedge is installed.  Package creation then fails because it looks in
LOCALBASE for the files.

From bulk build:

[...]
===> Installing for navigator3-3.04
install -d -o root -g wheel -m 555 /usr/X11R6/share/netscape
install -d -o root -g wheel -m 555 /usr/X11R6/share/netscape/nls
install -d -o root -g wheel -m 555 /usr/X11R6/share/netscape/java
install -c -o root -g wheel -m 555 /var/pkgsrc.orig/www/navigator3/work/netscape
 /usr/X11R6/bin
install -c -o root -g wheel -m 555 /var/pkgsrc.orig/www/navigator3/work/netscape
.bin /usr/X11R6/bin # XXX
install -c -o root -g wheel -m 555 /var/pkgsrc.orig/www/navigator3/work/movemail
 /usr/X11R6/bin
install -c -o root -g wheel -m 555 /var/pkgsrc.orig/www/navigator3/work/movemail
.bin /usr/X11R6/bin # XXX
install -c -o root -g wheel -m 444 /var/pkgsrc.orig/www/navigator3/work/nls/C /u
sr/X11R6/share/netscape/nls
install -c -o root -g wheel -m 444 /var/pkgsrc.orig/www/navigator3/work/nls/nls.
dir /usr/X11R6/share/netscape/nls
install -c -o root -g wheel -m 444 /var/pkgsrc.orig/www/navigator3/work/java_301
 /usr/X11R6/share/netscape/java
install -c -o root -g wheel -m 444 /var/pkgsrc.orig/www/navigator3/work/mailcap 
/usr/X11R6/share/netscape
ls: /usr/pkg/bin/movemail: No such file or directory
ls: /usr/pkg/bin/movemail.bin: No such file or directory
ls: /usr/pkg/bin/netscape: No such file or directory
ls: /usr/pkg/bin/netscape.bin: No such file or directory
ls: /usr/pkg/share/netscape/java/java_301: No such file or directory
ls: /usr/pkg/share/netscape/mailcap: No such file or directory
ls: /usr/pkg/share/netscape/nls/C: No such file or directory
ls: /usr/pkg/share/netscape/nls/nls.dir: No such file or directory
===> Registering installation for navigator3-3.04
pkg_create: can't stat `/usr/pkg/bin/netscape'
pkg_create: can't stat `/usr/pkg/bin/netscape.bin'
pkg_create: can't stat `/usr/pkg/bin/movemail'
pkg_create: can't stat `/usr/pkg/bin/movemail.bin'
pkg_create: can't stat `/usr/pkg/share/netscape/nls/C'
pkg_create: can't stat `/usr/pkg/share/netscape/nls/nls.dir'
pkg_create: can't stat `/usr/pkg/share/netscape/java/java_301'
pkg_create: can't stat `/usr/pkg/share/netscape/mailcap'
===> Building binary package for navigator3-3.04
pkg_create: can't stat `/usr/pkg/bin/netscape'
pkg_create: can't stat `/usr/pkg/bin/netscape.bin'
pkg_create: can't stat `/usr/pkg/bin/movemail'
pkg_create: can't stat `/usr/pkg/bin/movemail.bin'
pkg_create: can't stat `/usr/pkg/share/netscape/nls/C'
pkg_create: can't stat `/usr/pkg/share/netscape/nls/nls.dir'
pkg_create: can't stat `/usr/pkg/share/netscape/java/java_301'
pkg_create: can't stat `/usr/pkg/share/netscape/mailcap'
tar: can't add file bin/netscape : No such file or directory
tar: can't add file bin/netscape.bin : No such file or directory
tar: can't add file bin/movemail : No such file or directory
tar: can't add file bin/movemail.bin : No such file or directory
tar: can't add file share/netscape/nls/C : No such file or directory
tar: can't add file share/netscape/nls/nls.dir : No such file or directory
tar: can't add file share/netscape/java/java_301 : No such file or directory
tar: can't add file share/netscape/mailcap : No such file or directory
pkg_create: tar command failed with code 2048
Creating package /nsource/packages/i386/1.5/All/navigator3-3.04.tgz
Registering depends:.
Using SrcDir value of /usr/pkg
Creating gzip'd tar ball in '/nsource/packages/i386/1.5/All/navigator3-3.04.tgz'
*** Error code 1

Stop.
*** Error code 1

Stop.
*** Error code 1

Stop.
BULK> navigator3-3.04 was marked as broken:
-rw-r--r--  1 root  wheel  4674 Jun  7 14:39 .broken


Also, since one of the likely reasons why a person would install such
an old version of Netscape would be for testing the appearance of web
pages they're developing in multiple browsers, rename the startup
script to netscape3 so this package can coexist with the www/netscape
(version 4) package.  (This change was pre-approved on tech-pkg 2001-06-19.)


>How-To-Repeat:
( cd www/navigator3 && make package ) with xpkgwedge installed

>Fix:
Apply the following patch to www/navigator3.  The patch changes Makefile,
files/netscape.sh, pkg/PLIST, and scripts/configure.
(The change replaces X11BASE with PREFIX in most locations, and renames
netscape{,.bin} to netscape3{,.bin}.

diff -ur /source/sup/current/pkgsrc/www/navigator3/Makefile ./Makefile
--- /source/sup/current/pkgsrc/www/navigator3/Makefile	Sun Feb 18 06:15:03 2001
+++ ./Makefile	Wed Jun 20 17:29:13 2001
@@ -23,16 +23,16 @@
 NO_BUILD=		yes
 
 do-install:
-	${INSTALL_DATA_DIR} ${X11BASE}/share/netscape
-	${INSTALL_DATA_DIR} ${X11BASE}/share/netscape/nls
-	${INSTALL_DATA_DIR} ${X11BASE}/share/netscape/java
-	${INSTALL_SCRIPT} ${WRKSRC}/netscape ${X11BASE}/bin
-	${INSTALL_SCRIPT} ${WRKSRC}/netscape.bin ${X11BASE}/bin # XXX
-	${INSTALL_SCRIPT} ${WRKSRC}/movemail ${X11BASE}/bin
-	${INSTALL_SCRIPT} ${WRKSRC}/movemail.bin ${X11BASE}/bin # XXX
-	${INSTALL_DATA} ${WRKSRC}/nls/C ${X11BASE}/share/netscape/nls
-	${INSTALL_DATA} ${WRKSRC}/nls/nls.dir ${X11BASE}/share/netscape/nls
-	${INSTALL_DATA} ${WRKSRC}/java_301 ${X11BASE}/share/netscape/java
-	${INSTALL_DATA} ${WRKSRC}/mailcap ${X11BASE}/share/netscape
+	${INSTALL_DATA_DIR} ${PREFIX}/share/netscape
+	${INSTALL_DATA_DIR} ${PREFIX}/share/netscape/nls
+	${INSTALL_DATA_DIR} ${PREFIX}/share/netscape/java
+	${INSTALL_SCRIPT} ${WRKSRC}/netscape3 ${PREFIX}/bin
+	${INSTALL_SCRIPT} ${WRKSRC}/netscape3.bin ${PREFIX}/bin # XXX
+	${INSTALL_SCRIPT} ${WRKSRC}/movemail ${PREFIX}/bin
+	${INSTALL_SCRIPT} ${WRKSRC}/movemail.bin ${PREFIX}/bin # XXX
+	${INSTALL_DATA} ${WRKSRC}/nls/C ${PREFIX}/share/netscape/nls
+	${INSTALL_DATA} ${WRKSRC}/nls/nls.dir ${PREFIX}/share/netscape/nls
+	${INSTALL_DATA} ${WRKSRC}/java_301 ${PREFIX}/share/netscape/java
+	${INSTALL_DATA} ${WRKSRC}/mailcap ${PREFIX}/share/netscape
 
 .include "../../mk/bsd.pkg.mk"
diff -ur /source/sup/current/pkgsrc/www/navigator3/files/netscape.sh ./files/netscape.sh
--- /source/sup/current/pkgsrc/www/navigator3/files/netscape.sh	Wed Jul 21 18:09:02 1999
+++ ./files/netscape.sh	Wed Jun 20 17:28:47 2001
@@ -1,6 +1,6 @@
 #!/bin/sh
 export XKEYSYMDB ; XKEYSYMDB=@X11BASE@/lib/X11/XKeysymDB
-export XNLSPATH  ; XNLSPATH=@X11BASE@/share/netscape/nls
-export XAPPLRESDIR ; XAPPLRESDIR=@X11BASE@/lib/X11/app-defaults
-export CLASSPATH ; CLASSPATH=@X11BASE@/share/netscape/java/java_301
-exec @EXECDIR@/netscape.bin "$@"
+export XNLSPATH  ; XNLSPATH=@PREFIX@/share/netscape/nls
+export XAPPLRESDIR ; XAPPLRESDIR=@PREFIX@/lib/X11/app-defaults
+export CLASSPATH ; CLASSPATH=@PREFIX@/share/netscape/java/java_301
+exec @EXECDIR@/netscape3.bin "$@"
diff -ur /source/sup/current/pkgsrc/www/navigator3/pkg/PLIST ./pkg/PLIST
--- /source/sup/current/pkgsrc/www/navigator3/pkg/PLIST	Wed Jul 21 18:09:02 1999
+++ ./pkg/PLIST	Wed Jun 20 17:31:11 2001
@@ -1,6 +1,6 @@
 @comment $NetBSD: PLIST,v 1.1.1.1 1999/07/21 23:09:02 garbled Exp $
-bin/netscape
-bin/netscape.bin
+bin/netscape3
+bin/netscape3.bin
 bin/movemail
 bin/movemail.bin
 share/netscape/nls/C
diff -ur /source/sup/current/pkgsrc/www/navigator3/scripts/configure ./scripts/configure
--- /source/sup/current/pkgsrc/www/navigator3/scripts/configure	Wed Jul 21 18:09:02 1999
+++ ./scripts/configure	Wed Jun 20 17:28:39 2001
@@ -6,19 +6,19 @@
 *)	NSBINARY=foobar ;;
 esac
 
-if [ ! -f ${WRKSRC}/netscape.bin ] ; then
-    mv ${WRKSRC}/${NSBINARY} ${WRKSRC}/netscape.bin
+if [ ! -f ${WRKSRC}/netscape3.bin ] ; then
+    mv ${WRKSRC}/${NSBINARY} ${WRKSRC}/netscape3.bin
 fi
 if [ ! -f ${WRKSRC}/movemail.bin ] ; then
     mv ${WRKSRC}/movemail ${WRKSRC}/movemail.bin
 fi
 
-sed -e "s;@X11BASE@;${X11BASE};g" -e "s;@LIBDIR@;${LIBDIR};g" \
-    -e "s;@EXECDIR@;${X11BASE}/bin;g" \
-	${FILESDIR}/netscape.sh >${WRKSRC}/netscape
-chmod +x ${WRKSRC}/netscape
-sed -e "s;@X11BASE@;${X11BASE};g" -e "s;@LIBDIR@;${LIBDIR};g" \
-    -e "s;@EXECDIR@;${X11BASE}/bin;g" \
+sed -e "s;@X11BASE@;${X11BASE};g" -e "s;@PREFIX@;${PREFIX};g" \
+    -e "s;@EXECDIR@;${PREFIX}/bin;g" \
+	${FILESDIR}/netscape.sh >${WRKSRC}/netscape3
+chmod +x ${WRKSRC}/netscape3
+sed -e "s;@X11BASE@;${X11BASE};g" -e "s;@PREFIX@;${PREFIX};g" \
+    -e "s;@EXECDIR@;${PREFIX}/bin;g" \
 	${FILESDIR}/movemail.sh >${WRKSRC}/movemail
 chmod +x ${WRKSRC}/movemail
 
>Release-Note:
>Audit-Trail:
>Unformatted: