Subject: Re: bin/12876: NetBSD's INET6 patches to Postfix break non-INET6 features!
To: None <firstname.lastname@example.org,>
From: None <email@example.com>
Date: 05/10/2001 05:29:16
>> try gnu/dist/postfix/src/smtpd/smtpd_peer.c revision 1.3.
>I don't have to try it to know that it absolutely cannot work. You did
>not apply my changes. You could not have done the tests I suggested, at
>least not without -DINET6 or you too would know that your commit doesn't
>fix the bug.
>Please apply *all* of my changes, exactly as I made them if you don't
no. i don't take patches that does not relate to the PR itself.
>understand them, and then *test* them! They were primarily designed to
fair enough, i'll try to test. next time do not ever think of
including tons of costmetic changes which is not maintainable.
>> i still don't understand this "more than 17 letters" part.
>> your changes to hostname buffer length are totally cosmetic.
>An array of sizeof("255.255.255.255"), even +1, is not anywhere near
>long enough to hold your average fully qualified hostname..... I
>thought the comments I put in there to show what's being done at which
>stage would make this clear.
>BTW, I'm guessing that Wietse won't accept any INET6 patches that are
SO WHAT? thanks for your unrelated comment. it's up to wietse,
>I think the best way to fully fix this maze of
>conditional compilation would be to first fix the code to call the
>already present peer_name() from libglobal and then to provide an
>alternate peer_name6.c that's been changed to use getnameinfo() and
bzzzt. i confirmed with wietse and he said that peer_name is
deprecated and the new code should use smtpd/smtpd_peer.c.