Subject: Re: bin/12876: NetBSD's INET6 patches to Postfix break non-INET6 features!
To: None <itojun@iijlab.net>
From: Greg A. Woods <woods@weird.com>
List: netbsd-bugs
Date: 05/08/2001 20:36:40
[ On Wednesday, May 9, 2001 at 08:09:52 (+0900), itojun@iijlab.net wrote: ]
> Subject: Re: bin/12876: NetBSD's INET6 patches to Postfix break non-INET6 features! 
>
> 	sorry for the mess.  could you PLEASE identify which part of the
> 	diff is the important piece here?  there are a lot of non-related
> 	cosmetic changes included, and it prevents me from fixing the issue.

In my opinion it's all critical.  :-)

The changes to peer_name() are probably cosmetic because nothing
critical ever calls it, but since the code's there it should probably be
correct (I think the only fix in peer_name() is to add error logging).

The changes to the anything related to domain and host names should
probably be checked in with a separate comment (assuming you agree to
check them in! ;-), but that's easy because they're all in separate
files.

The really crictical fixes are all in smtpd_peer_init.c (if I remember
the name correctly)...

-- 
							Greg A. Woods

+1 416 218-0098      VE3TCP      <gwoods@acm.org>     <woods@robohack.ca>
Planix, Inc. <woods@planix.com>;   Secrets of the Weird <woods@weird.com>