Subject: Re: pkg/12276: Corrections for games/angband-{tty,x11}
To: Tomasz Luchowski <zuntum@eik.pl>
From: Todd Vierling <tv@wasabisystems.com>
List: netbsd-bugs
Date: 02/23/2001 15:22:59
On 23 Feb 2001, Tomasz Luchowski wrote:

: >Description:
: 	We should use ${INSTALL_DATA_DIR} and ${INSTALL_PROGRAM} instead of
: 	plain install... patch below.

: -	${INSTALL} -d -o bin -g games -m 0775 ${PREFIX}/share/angband
: +	${INSTALL_DATA_DIR} ${PREFIX}/share/angband

This is obviously wrong; it's missing the group "games".  Proper fix:

	${INSTALL_DATA_DIR} -g games -m 0775 ${PREFIX}/share/angband

(Note the absence of "-o bin" -- it should inherit BINOWN.)  Similarly, the
three INSTALL_PROGRAM fixes should remove the "-o bin"; for example:

: -	${INSTALL} -c -s -o bin -g games -m 2755 ${WRKSRC}/angband ${PREFIX}/bin
: +	${INSTALL_PROGRAM} -o bin -g games -m 2755 ${WRKSRC}/angband ${PREFIX}/bin

should be

	${INSTALL_PROGRAM} -g games -m 2755 ${WRKSRC}/angband ${PREFIX}/bin

-- 
-- Todd Vierling <tv@wasabisystems.com>  *  Wasabi NetBSD:  Run with it.
-- NetBSD 1.5 now available on CD-ROM  --  http://www.wasabisystems.com/