Subject: kern/12241: cut&paste error in if_tokensubr
To: None <gnats-bugs@gnats.netbsd.org>
From: None <mlelstv@serpens.de>
List: netbsd-bugs
Date: 02/19/2001 08:36:13
>Number:         12241
>Category:       kern
>Synopsis:       cut&paste error in if_tokensubr
>Confidential:   yes
>Severity:       serious
>Priority:       medium
>Responsible:    kern-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Feb 18 23:37:00 PST 2001
>Closed-Date:
>Last-Modified:
>Originator:     Michael van Elst
>Release:        NetBSD-current
>Organization:
	
>Environment:
	
System: NetBSD sagitta 1.5S NetBSD 1.5S (SAGITTA) #11: Sun Feb 18 18:32:44 PST 2
001 root@sagitta:/data/cvs/src/sys/arch/i386/compile/SAGITTA i386
Architecture: i386
Machine: i386

>Description:
The changes for ALTQ handling in if_tokensubr.c introduced a cut&paste error.

if_tokensubr.c:460-461 should read

	mflags = m->m_flags;
	len = m->m_pkthdr.len;

instead of

	len = m->m_flags;
	len = m->m_pkthdr.len;

As a result the if_omcasts counter is incremented on an undefined
variable.

>How-To-Repeat:
	look at version 1.14 of the if_tokensubr.c
>Fix:
	change line 460
>Release-Note:
>Audit-Trail:
>Unformatted:
 no
 Multicast counter isn't incremented correctly
 non-critical
 medium
 sw-bug