Subject: Re: port-arm32/12120: arm32 wdc drivers should use wdc_print_modes for a bit more info
To: Chris Gilbert <email@example.com>
From: Manuel Bouyer <firstname.lastname@example.org>
Date: 02/04/2001 18:13:02
On Sun, Feb 04, 2001 at 04:25:25PM +0000, Chris Gilbert wrote:
> Looking at sys/macppc/dev/wdc_obio.c it doesn't have this flag set, and it
> uses wdc_print_modes (AFAIR it's the original reason for having
> wdc_print_modes) Is it also wrong? or have I missed something? (which is
> probably more likely)
This front-end looks quite brocken, especially the adjust_timing() stuff.
It shoud use the set_modes callback instead, and assert WDC_CAPABILITY_MODE.
I'll look at this later (but I can't test it).
Note that it never updates PIO_mode and DMA_mode, so the infos printed
here are surely not accurate. I think it's there only to inform that
DMA is used.
Manuel Bouyer <email@example.com>