Subject: Re: bin/11072: usermod(8) mixes things up badly
To: None <agc@pkgsrc.org>
From: Hubert Feyrer <hubert.feyrer@informatik.fh-regensburg.de>
List: netbsd-bugs
Date: 09/25/2000 16:41:18
  This message is in MIME format.  The first part should be readable text,
  while the remaining parts are likely unreadable without MIME-aware tools.
  Send mail to mime@docserver.cac.washington.edu for more info.

--19724563.969890071889.JavaMail.imail.prickles
Content-Type: TEXT/PLAIN; CHARSET=US-ASCII
Content-ID: <Pine.GSO.4.21.0009251639592.20679@rfhpc8320.fh-regensburg.de>

On Mon, 25 Sep 2000, Alistair Crooks wrote:
> In line 865 of src/usr.sbin/user/user.c, change the up->u_comment reference
> to be up->u_shell (I've attached the full unified diff to this message).
> 
> This fixes the reported problem for me - now onto 11071.

Yes, confirmed working. Please commit. :-)


 - Hubert

-- 
Hubert Feyrer <hubert.feyrer@informatik.fh-regensburg.de>

--19724563.969890071889.JavaMail.imail.prickles
Content-Type: TEXT/PLAIN; CHARSET=US-ASCII
Content-ID: <Pine.GSO.4.21.0009251639593.20679@rfhpc8320.fh-regensburg.de>
Content-Description: 
Content-Disposition: ATTACHMENT; FILENAME=a

--- user.c	2000/09/25 13:38:08	1.1
+++ user.c	2000/09/25 13:52:26
@@ -862,7 +862,7 @@
 			memsave(&up->u_comment, pwp->pw_gecos, strlen(pwp->pw_gecos));
 		}
 		if (strcmp(up->u_shell, DEF_SHELL) == 0 && strcmp(pwp->pw_shell, DEF_SHELL) != 0) {
-			memsave(&up->u_comment, pwp->pw_shell, strlen(pwp->pw_shell));
+			memsave(&up->u_shell, pwp->pw_shell, strlen(pwp->pw_shell));
 		}
 	}
 	loginc = strlen(login);

--19724563.969890071889.JavaMail.imail.prickles--