Subject: kern/10555: kernel including pciide with PCIIDE_AMD756_ENABLEDMA couldn't compile.
To: None <gnats-bugs@gnats.netbsd.org>
From: None <mrt@notwork.org>
List: netbsd-bugs
Date: 07/10/2000 02:39:13
>Number:         10555
>Category:       kern
>Synopsis:       kernel including pciide with PCIIDE_AMD756_ENABLEDMA couldn't compile.
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    kern-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Jul 10 02:40:01 PDT 2000
>Closed-Date:
>Last-Modified:
>Originator:     MURATA, Shuuichirou
>Release:        NetBSD-current as of 20000710
>Organization:
>Environment:

System: NetBSD fons-adae.s.notwork.org 1.5B NetBSD 1.5B (KOTONOHA) #5: Sat Jul 8 10:44:20 JST 2000 mrt@fons-adae.s.notwork.org:/export/work/mrt/src/sys/arch/i386/compile/KOTONOHA i386

>Description:

kernel including pciide driver (pciide.c rev. 1.79) with
"options PCIIDE_AMD756_ENABLEDMA" couldn't compile due to
warning of unused variable `rev'.

>How-To-Repeat:

Add a line "options PCIIDE_AMD756_ENABLEDMA" to GENERIC and
config GENERIC and make it.

>Fix:

Apply following patch to /sys/dev/pci/pciide.c.

Index: pciide.c
===================================================================
RCS file: /cvs/cvsroot/syssrc/sys/dev/pci/pciide.c,v
retrieving revision 1.79
diff -u -r1.79 pciide.c
--- pciide.c	2000/07/07 13:54:25	1.79
+++ pciide.c	2000/07/10 09:20:47
@@ -1777,8 +1777,10 @@
 	struct ata_drive_datas *drvp;
 	struct pciide_channel *cp = (struct pciide_channel*)chp;
 	struct pciide_softc *sc = (struct pciide_softc *)cp->wdc_channel.wdc;
+#ifndef PCIIDE_AMD756_ENABLEDMA
 	int rev = PCI_REVISION(
 	    pci_conf_read(sc->sc_pc, sc->sc_tag, PCI_CLASS_REG));
+#endif
 
 	idedma_ctl = 0;
 	datatim_reg = pci_conf_read(sc->sc_pc, sc->sc_tag, AMD756_DATATIM);

>Release-Note:
>Audit-Trail:
>Unformatted: