Subject: bin/10203: share/tmac/Makefile does not have correct dependencies
To: None <gnats-bugs@gnats.netbsd.org>
From: Greg A. Woods <woods@weird.com>
List: netbsd-bugs
Date: 05/26/2000 11:23:12
>Number:         10203
>Category:       bin
>Synopsis:       share/tmac/Makefile does not have correct dependencies
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    bin-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri May 26 11:24:00 PDT 2000
>Closed-Date:
>Last-Modified:
>Originator:     Greg A. Woods
>Release:        2000/05/26
>Organization:
Planix, Inc.; Toronto, Ontario; Canada
>Environment:

NetBSD-current

>Description:

	The Makefile in share/tmac/Makefile does not correctly rebuild
	its target files when building the "install" target

>How-To-Repeat:

	$ cd /usr/src/share/tmac
	$ touch doc-syms
	$ make install

	Observe that tmac.doc-syms is neither rebuilt or installed.

>Fix:

	The problem is that the target files are treated as include
	files, which of course are their own sources according to
	bsd.prog.mk and therefore don't need to be built.  The fix is
	to treat them as scripts instead:

Index: share/tmac/Makefile
===================================================================
RCS file: /cvs/NetBSD/src/share/tmac/Makefile,v
retrieving revision 1.1.1.2
diff -c -r1.1.1.2 share/tmac/Makefile
*** share/tmac/Makefile	2000/03/21 00:31:57	1.1.1.2
--- share/tmac/Makefile	2000/05/26 17:48:40
***************
*** 4,12 ****
  # IF YOU ADD TO MSRCS, MAKE SURE YOU UPDATE `CATDEPS' IN bsd.man.mk!
  MSRCS=  andoc doc doc-ditroff doc-common doc-nroff doc-syms doc2html
  MMACS=  ${MSRCS:S@^@tmac.@g}
! INCS=	${MMACS}
! INCSDIR=${BINDIR}/tmac
! LINKS=	${INCSDIR}/tmac.andoc ${INCSDIR}/tmac.an
  CLEANFILES+= ${MMACS}
  
  TMACDIR?=${.CURDIR}
--- 4,12 ----
  # IF YOU ADD TO MSRCS, MAKE SURE YOU UPDATE `CATDEPS' IN bsd.man.mk!
  MSRCS=  andoc doc doc-ditroff doc-common doc-nroff doc-syms doc2html
  MMACS=  ${MSRCS:S@^@tmac.@g}
! SCRIPTS=${MMACS}
! SCRIPTDIR=${BINDIR}/tmac
! LINKS=	${SCRIPTDIR}/tmac.andoc ${SCRIPTDIR}/tmac.an
  CLEANFILES+= ${MMACS}
  
  TMACDIR?=${.CURDIR}
>Release-Note:
>Audit-Trail:
>Unformatted: