Subject: pkg/10161: files/category test is broken
To: None <gnats-bugs@gnats.netbsd.org>
From: None <dmcmahill@netbsd.org>
List: netbsd-bugs
Date: 05/20/2000 12:57:10
>Number:         10161
>Category:       pkg
>Synopsis:       files/category test is broken
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    pkg-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat May 20 12:58:00 PDT 2000
>Closed-Date:
>Last-Modified:
>Originator:     
>Release:        1.4.2<NetBSD-current source date>
>Organization:

>Environment:
	
System: NetBSD cowboy-burt 1.4.1 NetBSD 1.4.1 (COWBOY-BURT) #1: Sat Oct 2 21:08:08 EDT 1999 dan@cowboy-burt:/amd/dinah-moe/export/src/sys/arch/sparc/compile/COWBOY-BURT sparc


>Description:

bsd.pkg.subdir.mk uses the following test to see if a subdir is a category
or a package:
                        if [ -z "${_THISDIR_}" -a ! -d "files" ]; then \
                                ${ECHO_MSG} "===> category ${_THISDIR_}$${edir}"; \
                                ${MAKE} ${.TARGET:realinstall=install} \
                                        "_THISDIR_=${_THISDIR_}$${edir}/" || /usr/bin/true ; \
                        else \
                                ${ECHO_MSG} "===> package ${_THISDIR_}$${edir}"; \
                                ${MAKE} ${.TARGET:realinstall=install} \
                                        "_THISDIR_=${_THISDIR_}$${edir}/" || /usr/bin/true ; \
                        fi ; \

however, the files subdir doesn't exist on all pacakges, for example:

directory /usr/pkgsrc/archivers/gtar/files does not exist
directory /usr/pkgsrc/archivers/gzip/files does not exist
directory /usr/pkgsrc/cad/geda/files does not exist
directory /usr/pkgsrc/cross/COMMON/files does not exist
directory /usr/pkgsrc/databases/jdbc-postgresql/files does not exist
directory /usr/pkgsrc/databases/tcl-postgresql/files does not exist
directory /usr/pkgsrc/databases/tk-postgresql/files does not exist
directory /usr/pkgsrc/emulators/suse_linux/files does not exist
directory /usr/pkgsrc/games/freeciv-client/files does not exist
directory /usr/pkgsrc/games/freeciv-client-gtk/files does not exist
directory /usr/pkgsrc/games/freeciv-server/files does not exist
directory /usr/pkgsrc/games/nethack/files does not exist
directory /usr/pkgsrc/graphics/gimp-helpbrowser/files does not exist
directory /usr/pkgsrc/graphics/p5-PerlMagick/files does not exist
[snip....]
	
>How-To-Repeat:
cd /usr/pkgsrc/cad
make package

note that it says

===> category geda

instead of 

===> package geda
	
>Fix:
maybe check for  -d "../../mk/bsd.pkg.mk" instead?

	
>Release-Note:
>Audit-Trail:
>Unformatted: