Subject: port-sun3/8637: sun3 zs.c and si.c does not include "opt_ddb.h"
To: None <gnats-bugs@gnats.netbsd.org>
From: None <tsutsui@ceres.dti.ne.jp>
List: netbsd-bugs
Date: 10/16/1999 19:36:47
>Number:         8637
>Category:       port-sun3
>Synopsis:       sun3 zs.c and si.c does not include "opt_ddb.h"
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    port-sun3-maintainer (NetBSD/sun3 Portmaster)
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Oct 16 19:36:00 1999
>Last-Modified:
>Originator:     Izumi Tsutsui
>Organization:
Izumi Tsutsui	Himeji City, Japan
>Release:        NetBSD-current 1.4L 19991015
>Environment:
System: NetBSD 1.4L sun3/80

>Description:
sun3/dev/zs.c and sun3/dev/si.c does not include "opt_ddb.h".
"DDB" would not defined in si.c so Debugger() is never called.
zs.c does not use "#if DDB" etc. but it is used in <sys/systm.h>
to define Debugger() as cpu_Debugger(), so it causes
"Undefined symbol" error.

>How-To-Repeat:
Configure and make a sun3 GENERIC kernel.

---
ld -N -Ttext F8004000 -e start -S -o netbsd ${SYSTEM_OBJ} vers.o
zs.o: Undefined symbol `_Debugger' referenced from text segment
*** Error code 1

Stop.

>Fix:

Index: si.c
===================================================================
RCS file: /cvs/repository/src/sys/arch/sun3/dev/si.c,v
retrieving revision 1.1.1.1
diff -u -r1.1.1.1 si.c
--- si.c	1999/09/11 15:54:45	1.1.1.1
+++ si.c	1999/10/17 02:17:42
@@ -76,6 +76,8 @@
  * The autoconfiguration boilerplate came from Adam Glass.
  */
 
+#include "opt_ddb.h"
+
 #include <sys/param.h>
 #include <sys/systm.h>
 #include <sys/errno.h>
Index: zs.c
===================================================================
RCS file: /cvs/repository/src/sys/arch/sun3/dev/zs.c,v
retrieving revision 1.1.1.1
diff -u -r1.1.1.1 zs.c
--- zs.c	1999/09/11 15:54:46	1.1.1.1
+++ zs.c	1999/10/16 21:21:51
@@ -44,6 +44,8 @@
  * Sun keyboard/mouse uses the zs_kbd/zs_ms slaves.
  */
 
+#include "opt_ddb.h"
+
 #include <sys/param.h>
 #include <sys/systm.h>
 #include <sys/conf.h>

>Audit-Trail:
>Unformatted: