Subject: lib/7885: ttylock(3) ignores flags and locker parameters
To: None <gnats-bugs@gnats.netbsd.org>
From: Kip Rugger <kbr@pangea.ca>
List: netbsd-bugs
Date: 06/30/1999 13:35:46
>Number:         7885
>Category:       lib
>Synopsis:       ttylock(3) ignores flags and locker parameters
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    lib-bug-people (Library Bug People)
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed Jun 30 13:35:01 1999
>Last-Modified:
>Originator:     Kip Rugger
>Organization:
	
>Release:        <NetBSD-current source date> NetBSD-1.4
>Environment:
	
System: NetBSD darkstar 1.4 NetBSD 1.4 (RUGGER) #14: Wed Jun 9 19:14:28 CDT 1999 kbr@rugger:/usr/src/sys/arch/i386/compile/RUGGER i386


>Description:
	
ttylock(3) calls pidlock(3) to do the real work, but fails to pass
the flags and locker parameters on to pidlock(3).  This breaks the
documented behaviour.
>How-To-Repeat:
	
>Fix:
	

--- /usr/src/lib/libutil/pidlock.c.dist14	Wed Jun 30 14:22:20 1999
+++ /usr/src/lib/libutil/pidlock.c	Wed Jun 30 14:24:40 1999
@@ -211,7 +211,7 @@
 	/* do the lock */
 	strcpy(lockfile, LOCKPATH);
 	strncat(lockfile, tty, MAXPATHLEN-strlen(LOCKPATH));
-	return pidlock(lockfile, 0, 0, 0);
+	return pidlock(lockfile, flags, locker, 0);
 }
 
 int
>Audit-Trail:
>Unformatted:
sw-bug