Subject: port-mips/7304: mips/locore.S does not include machine/endian.h
To: None <gnats-bugs@gnats.netbsd.org>
From: Izumi Tsutsui <tsutsui@ceres.dti.ne.jp>
List: netbsd-bugs
Date: 04/02/1999 18:33:29
>Number:         7304
>Category:       port-mips
>Synopsis:       mips/locore.S does not include machine/endian.h
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    port-mips-maintainer (NetBSD/mips Portmasters)
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Apr  2 01:35:01 1999
>Last-Modified:
>Originator:     Izumi Tsutsui
>Organization:
Izumi Tsutsui	Himeji City Japan
>Release:        NetBSD-current supped on 19990324
>Environment:
System: NetBSD/newsmips 1.3K, maybe all mips ports

>Description:
arch/mips/mips/locore.S does not include machine/endian.h,
so `#if BYTE_ORDER == LITTLE_ENDIAN' would not work correctly.

>How-To-Repeat:
Do make depend on mips system and see the .depend file.
locore.o does not depend machine/endian.h.

>Fix:
Just include machine/endian.h in locore.S.

--- sys/arch/mips/mips/locore.S.orig	Mon Mar  1 21:13:35 1999
+++ sys/arch/mips/mips/locore.S	Wed Mar 24 12:40:05 1999
@@ -70,6 +70,7 @@
 #endif
 
 #include <machine/param.h>
+#include <machine/endian.h>
 #include <mips/asm.h>
 #include <mips/cpuregs.h>
 
>Audit-Trail:
>Unformatted: