Subject: pkg/6389: gnome-core package fails to compile
To: None <gnats-bugs@gnats.netbsd.org>
From: None <cliff@snipe444.org>
List: netbsd-bugs
Date: 10/31/1998 16:43:37
>Number:         6389
>Category:       pkg
>Synopsis:       package gnome-core fails to compile
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    gnats-admin (GNATS administrator)
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Oct 31 16:50:01 1998
>Last-Modified:
>Originator:     Clifford Wright
>Organization:
	
>Release:        gnome-core-0.30
>Environment:
	
System: NetBSD vixen 1.3 NetBSD 1.3 (VIXEN) #6: Thu Apr 9 01:18:13 PDT 1998 cliff@vixen:/usr/src/sys/arch/i386/compile/VIXEN i386


>Description:
	
	The gnome-core package failed to complete due to a compilation error
	in the file applets/modemlights/modemlights.c. The patches in patch-ac
	seemed to use items not in 1.3.2. So once again I wonder if the
	package system is supposed to work against current not 1.3.2.
	The patch seems to assume ifreq has changed, and that a new ioctl
	has been defined. I include my quick hack patch to the patch
	below for 1.3.2.

--- modemlights.c.distrib	Wed Oct 28 00:50:16 1998
+++ modemlights.c	Wed Oct 28 21:49:21 1998
@@ -222,7 +222,7 @@
 	struct 	ppp_stats stats;
 
 	memset(&ifreq, 0, sizeof(ifreq));
-#if (defined(BSD) && BSD >= 199506)
+#if (defined(BSD) && BSD >= 199506) || defined(__NetBSD__)
 	strncpy(ifreq.ifr_name, device_name, IFNAMSIZ);
 #else
 	strncpy(ifreq.ifr_ifrn.ifrn_name, device_name, IFNAMSIZ);
@@ -231,7 +231,11 @@
 #if (defined(BSD) && BSD >= 199506)
 	if ((ioctl(ip_socket,SIOCGPPPSTATS,(caddr_t)&ifreq) < 0))
 #else
+#if defined(__NetBSD__)
+	if ((ioctl(ip_socket,SIOCGIFFLAGS,(caddr_t)&ifreq) < 0))
+#else
 	if ((ioctl(ip_socket,SIOCDEVPRIVATE,(caddr_t)&ifreq) < 0))
+#endif /* NetBSD */
 #endif /* 4.4-BSD derived */
 			{
 				/* failure means ppp is not up */

>How-To-Repeat:
	
	cd /usr/pkgsrc/x11/gnome-core
	make
>Fix:
	
	Maybe none if this package is not intended to run on 1.3.2
>Audit-Trail:
>Unformatted: