Subject: kern/6070: adv.c makes an unprotected call to Debugger()
To: None <gnats-bugs@gnats.netbsd.org>
From: Gary D. Duzan <gary@wheel.tiac.net>
List: netbsd-bugs
Date: 08/30/1998 12:33:43
>Number:         6070
>Category:       kern
>Synopsis:       adv.c makes an unprotected call to Debugger()
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    kern-bug-people (Kernel Bug People)
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Aug 30 16:20:07 1998
>Last-Modified:
>Originator:     Gary D. Duzan
>Organization:
	As little as possible
>Release:        Sun Aug 30 1998
>Environment:
System: NetBSD wheel.tiac.net 1.3G NetBSD 1.3G (WHEEL) #0: Sat Aug 29 10:39:24 EDT 1998 gary@wheel.tiac.net:/disk0/usr/local/build/NetBSD/src/sys/arch/i386/compile/WHEEL i386


>Description:

wheel { ~/src/sys/arch/i386/compile/INSTALL } # make
making sure the kern library is up to date...
`libkern.o' is up to date.
making sure the compat library is up to date...
`libcompat.a' is up to date.
sh ../../../../conf/newvers.sh
cc  -O2 -Werror -Wall -Wmissing-prototypes -Wstrict-prototypes -I. -I../../../../arch -I../../../.. -nostdinc -DMEMORY_DISK_HOOKS -DMEMORY_DISK_IS_ROOT -DMEMORY_DISK_SERVER="0" -DMINIROOTSIZE="0xc02" -DMSGBUFSIZE="(128 * 1024)" -DMAXUSERS=32 -D_KERNEL  -Di386  -c vers.c
rm -f netbsd
ld -z -Ttext F0100000 -e start -X -o netbsd ${SYSTEM_OBJ} vers.o
adv.o: Undefined symbol `_Debugger' referenced from text segment
*** Error code 1

Stop.

>How-To-Repeat:
	As above
>Fix:
Stolen from uha.c:

*** /usr/src/sys/dev/ic/adv.c	Sun Aug 30 07:12:32 1998
--- adv.c	Sun Aug 30 12:24:54 1998
***************
*** 63,68 ****
--- 63,73 ----
  #include <dev/ic/adv.h>
  #include <dev/ic/advlib.h>
  
+ #ifndef   DDB
+ #define Debugger() panic("should call debugger here (adv.c)")
+ #endif /* ! DDB */
+ 
+ 
  /******************************************************************************/
  
  
>Audit-Trail:
>Unformatted: