Subject: bin/5875: timed gives overly verbose syslog output
To: None <gnats-bugs@gnats.netbsd.org>
From: Tim Rightnour <root@polaris.garbled.net>
List: netbsd-bugs
Date: 07/30/1998 02:48:40
>Number:         5875
>Category:       bin
>Synopsis:       timed gives overly verbose syslog output
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    bin-bug-people (Utility Bug People)
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Thu Jul 30 02:35:01 1998
>Last-Modified:
>Originator:     Tim Rightnour
>Organization:
Tim Rightnour    -  root@garbled.net
http://www.zynetwc.com/~garbled/garbled.html
>Release:        1.3<NetBSD-current source date>
>Environment:
	
System: NetBSD polaris 1.3 NetBSD 1.3 (POLARIS) #0: Thu Mar 26 13:17:18 MST 1998 root@polaris:/usr/src/sys/arch/i386/compile/POLARIS i386


>Description:
This patch is from current supped today.
timed gives an overly verbose syslog error when it detects it's link to a
remote host is down..  
Jul 30 01:38:59 polaris timed[2037]: /usr/src/usr.sbin/timed/timed/master.c 173: sendto 206.103.182.40: No route to host

This is a bit much.. Knowing the line number and source file hardly does the
user any good unless he has source code.. this really shouldn't be in my
syslog.
	
>How-To-Repeat:
run timed -M  then unplug a network cable.
	
>Fix:
If the user wants this much debugging, the trace facilities still provide it..
there is no reason to have such verbose debugging messages in the syslog code.

--- globals.h.orig	Thu Jul 30 01:43:12 1998
+++ globals.h	Thu Jul 30 01:43:50 1998
@@ -177,4 +177,3 @@
 	int st_errno = errno;						\
-	syslog(LOG_ERR, "%s %d: sendto %s: %m",				\
-		__FILE__, __LINE__, inet_ntoa(addr));			\
+	syslog(LOG_ERR, "sendto %s: %m",inet_ntoa(addr));		\
 	if (trace)							\

	
>Audit-Trail:
>Unformatted: