Subject: kern/5717: if_strip.c doesn't compile
To: None <gnats-bugs@gnats.netbsd.org>
From: Dave Huang <khym@bga.com>
List: netbsd-bugs
Date: 07/06/1998 18:22:23
>Number:         5717
>Category:       kern
>Synopsis:       if_strip.c doesn't compile
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    kern-bug-people (Kernel Bug People)
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Jul  6 16:35:00 1998
>Last-Modified:
>Originator:     Dave Huang
>Organization:
Name: Dave Huang     |   Mammal, mammal / their names are called /
INet: khym@bga.com   |   they raise a paw / the bat, the cat /
FurryMUCK: Dahan     |   dolphin and dog / koala bear and hog -- TMBG
Dahan: Hani G Y+C 22 Y++ L+++ W- C++ T++ A+ E+ S++ V++ F- Q+++ P+ B+ PA+ PL++
>Release:        NetBSD-current as of July 6, 1998
>Environment:
	
System: NetBSD dahan.metonymy.com 1.3F NetBSD 1.3F (SPIFF) #230: Mon Jul 6 17:30:16 CDT 1998 khym@dahan.metonymy.com:/usr/src.local/sys/arch/i386/compile/SPIFF i386


>Description:
	Line 126 of if_strip.c does an "#if INET" instead of "#ifdef
INET". This causes the compile to fail with:
cc  -O2 -Werror -Wall -Wmissing-prototypes -Wstrict-prototypes -Wno-main -I. -I../../../../arch -I../../../.. -nostdinc -DSYSVMSG -DSYSVSEM -DSYSVSHM -DLKM -DDIAGNOSTIC -DCOMPAT_43 -DMAXUSERS=32 -D_KERNEL  -Di386  -c ../../../../net/if_strip.c
../../../../net/if_strip.c:126: syntax error
../../../../net/if_strip.c:132: #error Starmode Radio IP configured without configuring inet?
*** Error code 1

Stop.

>How-To-Repeat:
	Compile a kernel with the strip driver. (Such as the i386 GENERIC).
>Fix:
--- /usr/src/sys/net/if_strip.c	Sun Jul  5 06:11:43 1998
+++ if_strip.c	Mon Jul  6 18:14:05 1998
@@ -123,7 +123,7 @@
 #include <net/netisr.h>
 #include <net/route.h>
 
-#if INET
+#ifdef INET
 #include <netinet/in.h>
 #include <netinet/in_systm.h>
 #include <netinet/in_var.h>

>Audit-Trail:
>Unformatted: