>Number:         5701
>Category:       bin
>Synopsis:       The WINS1 and WINS2 protocol constants for pppd are wrong
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    bin-bug-people (Utility Bug People)
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Jul  4 03:20:00 1998
>Last-Modified:
>Originator:     Terry Moore
>Organization:
	MCCI, Ithaca NY
>Release:        <NetBSD-current source date> 1.3.2
>Environment:
	
System: NetBSD tmmnote.mcci.com 1.3.2 NetBSD 1.3.2 (MCCI_735DX_APM) #1: Wed Jun 3 18:20:18 EDT 1998 root@tmmnote.mcci.com:/usr/src/sys/arch/i386/compile/MCCI_735DX_APM i386


>Description:
	RFC1877 specifies four option codes for IPCP negotiation:

	0x81 is primary DNS address
	0x82 is primary NBNS (WINS) address
	0x83 is secondary DNS
	0x84 is secondary NBNS.

	In src/usr.sbin/pppd/pppd/ipcp.h, the corresponding constants for 
	the NBNS option codes are incorrect; 

	CI_MS_WINS1 is 128 (should be 130)
	CI_MS_WINS2 is 130 (should be 132)

	The practical effect of this is small, because at present WINS
	is not very relevant to PPPD.
>How-To-Repeat:
	
>Fix:
	Here's a suggested correction.

*** ipcp.h	Sat Sep 27 08:14:39 1997
--- /tmp/ipcp.h	Sat Jul  4 02:01:18 1998
***************
*** 28,37 ****
  #define CI_COMPRESSTYPE	2	/* Compression Type */
  #define	CI_ADDR		3
  
- #define CI_MS_WINS1	128	/* Primary WINS value */
  #define CI_MS_DNS1	129	/* Primary DNS value */
! #define CI_MS_WINS2	130	/* Secondary WINS value */
  #define CI_MS_DNS2	131	/* Secondary DNS value */
  
  #define MAX_STATES 16		/* from slcompress.h */
  
--- 28,37 ----
  #define CI_COMPRESSTYPE	2	/* Compression Type */
  #define	CI_ADDR		3
  
  #define CI_MS_DNS1	129	/* Primary DNS value */
! #define CI_MS_WINS1	130	/* Primary WINS value */
  #define CI_MS_DNS2	131	/* Secondary DNS value */
+ #define CI_MS_WINS2	132	/* Secondary WINS value */
  
  #define MAX_STATES 16		/* from slcompress.h */
  
>Audit-Trail:
>Unformatted: