Subject: pkg/5416: x11, devel pkg Makefiles don't work
To: None <gnats-bugs@gnats.netbsd.org>
From: None <bgrayson@ece.utexas.edu>
List: netbsd-bugs
Date: 05/07/1998 11:01:03
>Number:         5416
>Category:       pkg
>Synopsis:       The comments about CONFLICTS in x11/ and devel/ Makefiles cause problems
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    gnats-admin (GNATS administrator)
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu May  7 09:05:01 1998
>Last-Modified:
>Originator:     Brian Grayson
>Organization:
	Parallel and Distributed Systems
	Electrical and Computer Engineering
	The University of Texas at Austin
>Release:        late Apr 1998
>Environment:
NetBSD marvin 1.3E NetBSD 1.3E (MARVIN) #39: Thu Apr 23 10:09:22 CDT 1998     bgrayson@marvin:/a/c3p0/home/c3p0/src/sys/arch/i386/compile/MARVIN i386

>Description:
	The Makefiles in the pkgsrc x11 and devel directories have a
	comment about how we would need a CONFLICTS feature for
	something.  These comments start with a tab, so make
	chokes on them:
	# cd /usr/pkgsrc/x11
	# make clean
	"Makefile", line 10: Unassociated shell command "# have a CONFLICTS feature (installs same"
	"Makefile", line 11: Unassociated shell command "# files like Xaw3d)."
	Fatal errors encountered -- cannot continue

	
>How-To-Repeat:
	
>Fix:
	Either put a # at the beginning of the line, or change
	the leading tab to a space, or some similar fix.
	It's a matter of taste, but I don't like right-margin
	multi-line ``hanging'' comments, so I'd do something like:

...
    SUBDIR += Xaw3d
##  Don't enable Xaw-Xpm by default unless we have a
##  CONFLICTS feature (Xaw-Xpm installs same files like Xaw3d).
##    SUBDIR += Xaw-Xpm
#    SUBDIR += afterstep
    SUBDIR += amiwm
    SUBDIR += asclock
...
	
>Audit-Trail:
>Unformatted: