Subject: Re: kern/5260: clean up ISA bus autoconf printing
To: None <soren@t.dk>
From: Chris G. Demetriou <cgd@pa.dec.com>
List: netbsd-bugs
Date: 04/07/1998 18:28:29
> Also, perhaps the isaprint should output io port sizes the same way as isapnp.c .
> [ ... ]
> --- src/sys/dev/isa/isa.c.orig	Sun Mar 29 23:32:24 1998
> +++ src/sys/dev/isa/isa.c	Tue Apr  7 17:34:56 1998
> @@ -145,7 +145,7 @@
>  	if (ia->ia_iosize)
>  		printf(" port 0x%x", ia->ia_iobase);
>  	if (ia->ia_iosize > 1)
> -		printf("-0x%x", ia->ia_iobase + ia->ia_iosize - 1);
> +		printf("/%d", ia->ia_iosize);
>  	if (ia->ia_msize)
>  		printf(" iomem 0x%x", ia->ia_maddr);
>  	if (ia->ia_msize > 1)

It should not.

for ISA, the io base and size information are locators.  locator data
should be able to be pasted, verbatim, from kernel boot message output
into kernel config files.

For isapnp, doing it the way it's done now is OK, because they're
_not_ locators, there.


If you want to make these two things consistent, there are two
possible 'right' ways to do it:

	(1) change isapnp so that its printouts look like the ISA
	    printouts, or

	(2) change 'config' so that it allows specification of
	    locators that look like that.

(It's not obvious that the latter is either a good idea, or practical
to implement, so as far as i'm concerned, you're left with the former.
In any case, I don't think it's worthwhile.)



cgd