>Number:         5252
>Category:       port-mips
>Synopsis:       Inconsistent declarations of kdbpeek
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    gnats-admin (GNATS administrator)
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Apr  4 08:35:01 1998
>Last-Modified:
>Originator:     Erik Bertelsen
>Organization:
	
>Release:        NetBSD-current 3 Apr 1998
>Environment:
	
System: NetBSD aarhus1.uni-c.dk 1.3E NetBSD 1.3E (AARHUS1) #45: Wed Mar 4 21:22:25 MET 1998 erik@aarhus1.uni-c.dk:/home/src/sys/arch/pmax/compile/AARHUS1 pmax


>Description:
	Compilation errors causes by insconsistent declarations of kdbpeek
>How-To-Repeat:
>Fix:
	The patch below changes the declaration of kdbpeek in mips/
	include/trap.h to be consistent with its definition. Furthermore
	an explicit declaration in a .c file is removed -- this
	declaration is already provided by trap.h.
	The compilation errors were observed while building a pmax
	kernel with options DEBUG.

Index: include/trap.h
===================================================================
RCS file: /sw/cvs-base/src/sys/arch/mips/include/trap.h,v
retrieving revision 1.1.1.2
diff -c -r1.1.1.2 trap.h
*** trap.h	1998/03/27 20:04:21	1.1.1.2
--- trap.h	1998/04/04 18:13:56
***************
*** 52,58 ****
  
  #ifdef DEBUG
  extern int cpu_singlestep __P((register struct proc *p)); 
! extern int kdbpeek __P((int addr));
  #endif
  
  
--- 52,58 ----
  
  #ifdef DEBUG
  extern int cpu_singlestep __P((register struct proc *p)); 
! extern int kdbpeek __P((vm_offset_t addr));
  #endif
  
  
Index: mips/db_interface.c
===================================================================
RCS file: /sw/cvs-base/src/sys/arch/mips/mips/db_interface.c,v
retrieving revision 1.1.1.4
diff -c -r1.1.1.4 db_interface.c
*** db_interface.c	1998/01/13 22:38:07	1.1.1.4
--- db_interface.c	1998/04/04 18:13:57
***************
*** 63,69 ****
  void db_tlbdump_cmd __P((db_expr_t addr, int have_addr, db_expr_t count,
  	 char *modif));
  
- extern int	kdbpeek __P((vm_offset_t addr));
  extern void	kdbpoke __P((vm_offset_t addr, int newval));
  extern unsigned MachEmulateBranch __P((unsigned *regsPtr,
       unsigned instPC, unsigned fpcCSR, int allowNonBranch));
--- 63,68 ----


---Regards
Erik Bertelsen
>Audit-Trail:
>Unformatted: