Subject: pkg/4784: pkgsrc/mail/metamail installs bogus .orig files to ${PREFIX}/bin
To: None <gnats-bugs@gnats.netbsd.org>
From: None <frueauf@ira.uka.de>
List: netbsd-bugs
Date: 01/06/1998 01:21:24
>Number:         4784
>Category:       pkg
>Synopsis:       pkgsrc/mail/metamail installs bogus .orig files to ${PREFIX}/bin
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    gnats-admin (GNATS administrator)
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Mon Jan  5 16:34:59 1998
>Last-Modified:
>Originator:     Thorsten Frueauf
>Organization:
private
	
>Release:        <NetBSD-current source date> NetBSD 1.3
>Environment:
	
System: NetBSD cyberlap 1.3 NetBSD 1.3 (CYBERLAP) #4: Tue Dec 30 18:22:30 MET 1997 frueauf@cyberlap:/usr/src/sys/arch/i386/compile/CYBERLAP i386


>Description:
	
`make patch` installs the patches/patch-a? files which leaves back *.orig
files. This is a problem if the Makefile of the package installs all files
in a dir - the *.orig files get installed too. This is the case with
pkgsrc/mail/metamail.

>How-To-Repeat:
	
$ cd /usr/pkgsrc/mail/metamail
$ make install
$ ls -la ${PREFIX}/bin/*.orig:
-rwxr-xr-x  1 root  wheel  6325 Jan  6 00:25 showaudio.orig
-rwxr-xr-x  1 root  wheel  6224 Jan  6 00:25 showexternal.orig
-rwxr-xr-x  1 root  wheel  2462 Jan  6 00:25 showpartial.orig
-rwxr-xr-x  1 root  wheel  2775 Jan  6 00:25 showpicture.orig
-rwxr-xr-x  1 root  wheel  1097 Jan  6 00:25 sun2mime.orig

$ pkg_delete mm2.7
$ ls -la ${PREFIX}/bin/*.orig:
-rwxr-xr-x  1 root  wheel  6325 Jan  6 00:25 showaudio.orig
-rwxr-xr-x  1 root  wheel  6224 Jan  6 00:25 showexternal.orig
-rwxr-xr-x  1 root  wheel  2462 Jan  6 00:25 showpartial.orig
-rwxr-xr-x  1 root  wheel  2775 Jan  6 00:25 showpicture.orig

All but sun2mime.orig remain there, sun2mime.orig is in pkg/PLIST for some
reason, but I don't think it should be.

>Fix:
	
The following patch worked for me, it also fixes pkg/PLIST.

--- Makefile-orig	Fri Nov 21 12:58:12 1997
+++ Makefile	Tue Jan  6 01:04:43 1998
@@ -24,4 +24,7 @@
 		showpicture.1 splitmail.1
 MAN4=		mailcap.4
 
+post-patch:
+	rm -f ${WRKDIR}/mm2.7/src/bin/*.orig
+
 .include <bsd.port.mk>
--- pkg/PLIST-orig	Fri Nov 21 12:58:13 1997
+++ pkg/PLIST	Tue Jan  6 00:45:13 1998
@@ -25,7 +25,6 @@
 bin/sun-message.csh
 bin/sun-to-mime
 bin/sun2mime
-bin/sun2mime.orig
 lib/metamail/fonts/heb6x13.pcf
 lib/metamail/fonts/heb8x13.pcf
 lib/metamail/fonts/heb8x13B.pcf
>Audit-Trail:
>Unformatted:
pkgsrc/mail/metamail installs bogus .orig files to ${PREFIX}/bin