Subject: bin/4705: typo in sysinst:label.c leads to bogus overlap warning
To: None <gnats-bugs@gnats.netbsd.org>
From: Bill Sommerfeld <sommerfeld@orchard.arlington.ma.us>
List: netbsd-bugs
Date: 12/17/1997 04:49:02
>Number:         4705
>Category:       bin
>Synopsis:       typo in sysinst:label.c leads to bogus overlap warning
>Confidential:   no
>Severity:       critical
>Priority:       high
>Responsible:    bin-bug-people (Utility Bug People)
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Dec 16 21:05:01 1997
>Last-Modified:
>Originator:     Bill Sommerfeld
>Organization:
	
>Release:        971210
>Environment:
	
System: NetBSD orchard.arlington.ma.us 1.3_ALPHA NetBSD 1.3_ALPHA (ORCHARD) #12: Sat Nov 8 09:13:50 EST 1997 sommerfeld@stack.ch.apollo.hp.com:/usr/sommerfeld/NetBSD-1.3/src/sys/arch/i386/compile/ORCHARD i386


>Description:
	if partitions `a' and `b' aren't adjacent, the new sysinst code
	reports them as overlapping.

>How-To-Repeat:
	slice `a' in half, and create `f' in the second half..

>Fix:
	[compiles, untested at this point..]
	
diff -c -r1.1.2.2 label.c
*** label.c     1997/12/05 14:46:57     1.1.2.2
--- label.c     1997/12/17 04:48:58
***************
*** 119,125 ****
                                continue;
  
                        jstart = jp[D_OFFSET];
!                       jstop = jstart = jp[D_SIZE];
  
                        /* overlap? */
                        if ((istart <= jstart && jstart < istop) ||
--- 119,125 ----
                                continue;
  
                        jstart = jp[D_OFFSET];
!                       jstop = jstart + jp[D_SIZE];
  
                        /* overlap? */
                        if ((istart <= jstart && jstart < istop) ||
>Audit-Trail:
>Unformatted: