Subject: bin/4462: mount_nfs should use variable "nfsproto"
To: None <gnats-bugs@gnats.netbsd.org>
From: Matthias Scheler <tron@lyssa.owl.de>
List: netbsd-bugs
Date: 11/10/1997 22:02:47
>Number:         4462
>Category:       bin
>Synopsis:       mount_nfs should use variable "nfsproto"
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    bin-bug-people (Utility Bug People)
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Nov 10 13:05:06 1997
>Last-Modified:
>Originator:     Matthias Scheler
>Organization:
Matthias Scheler                                http://home.owl.de/~tron/
>Release:        971103
>Environment:
System: NetBSD lyssa 1.3_ALPHA NetBSD 1.3_ALPHA (LYSSA) #1: Thu Nov 6 01:44:09 MET 1997 tron@lyssa:/src/src/sys/arch/i386/compile/LYSSA i386

>Description:
"mount_nfs" keeps track of the used IP protocol in variable called
"nfsproto" but doesn't use it later.

>How-To-Repeat:
Look into "src/sbin/mount_nfs.c".

>Fix:
*** src/sbin/mount_nfs/mount_nfs.c.orig	Sun Oct 19 15:27:26 1997
--- src/sbin/mount_nfs/mount_nfs.c	Mon Nov 10 21:56:00 1997
*************** tryagain:
*** 646,653 ****
  		saddr.sin_family = AF_INET;
  		saddr.sin_port = htons(PMAPPORT);
  		if ((tport = pmap_getport(&saddr, RPCPROG_NFS,
! 		    nfsvers, nfsargsp->sotype == SOCK_STREAM ? IPPROTO_TCP :
! 		    IPPROTO_UDP)) == 0) {
  			if ((opflags & ISBGRND) == 0)
  				clnt_pcreateerror("NFS Portmap");
  		} else {
--- 646,652 ----
  		saddr.sin_family = AF_INET;
  		saddr.sin_port = htons(PMAPPORT);
  		if ((tport = pmap_getport(&saddr, RPCPROG_NFS,
! 		    nfsvers, nfsproto)) == 0) {
  			if ((opflags & ISBGRND) == 0)
  				clnt_pcreateerror("NFS Portmap");
  		} else {
>Audit-Trail:
>Unformatted: