Subject: Re: kern/3753: cyclades driver is broken
To: Wolfgang Solfrank <firstname.lastname@example.org>
From: Chris G. Demetriou <email@example.com>
Date: 06/17/1997 09:40:12
>Hmm, I think that since the low 4 bits of memory mapping registers are by
>definition read-only, the right solution is to fix pci_mapreg_map to accept the
>unmodified call and ignore the sense of the PCI_MAPREG_MEM_TYPE_32BIT_1M bit.
I don't think so. The point of supplying those bits are so that the
driver can make sure it's actually mapping the kind of region it
thinks it's supposed to be getting.
The driver knows (or should know, if people hacking on the driver had
the documentation 8-) what type of region each mapping register maps.
It's a nice sanity-check, to prevent stupid driver bogons and problems
caused by changes to the board not otherwise recognized by the driver
and/or PCI code.