Subject: port-mac68k/3650: redundant ?! mac68k/pcb.h
To: None <gnats-bugs@gnats.netbsd.org>
From: Erik Bertelsen <erik@erik-be.uni-c.dk>
List: netbsd-bugs
Date: 05/19/1997 18:42:34
>Number:         3650
>Category:       port-mac68k
>Synopsis:       redundant ?! mac68k/pcb.h
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    gnats-admin (GNATS administrator)
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon May 19 07:50:01 1997
>Last-Modified:
>Originator:     Erik Bertelsen
>Organization:
	
>Release:        NetBSD-current 19 May 1997
>Environment:
System: NetBSD erik-be.uni-c.dk 1.2E NetBSD 1.2E (ERIKBE) #26: Tue May 13 18:53:37 MEST 1997 erik@erik-be.uni-c.dk:/sw/NetBSD/src/sys/arch/i386/compile/ERIKBE i386


>Description:
	arch/mac68k/include/pcb.h is almost a copy of arch/m68k/include/pcb.h.

	The version in m68k/include was created ca. 1. april 1997. It is
	equivalent to the version in mac68k/include except for one difference:
	The mac68k version has a final field int pcb_exec[16] which seems
	to be intended to cover the struct md_coredump declared a few lines
	further down in this header.

	I suggest that mac68k/include/pcb.h be reduced to a include of
	m68k/include/pcb.h unless there is a good reason for the extra
	field pcb_exec, which does not seem to be used anywhere in the
	kernel.

	Keeping two almost identical headers in {m68k,mac68k}/includes/pch.h
	is at the best confusing, and a possible source for errors.

	regards
	Erik Bertelsen
>How-To-Repeat:
>Fix:
>Audit-Trail:
>Unformatted: