Subject: port-amiga/3622: /src/sys/adosfs/advnops.c contains a typo
To: None <gnats-bugs@gnats.netbsd.org>
From: None <frueauf@ira.uka.de>
List: netbsd-bugs
Date: 05/14/1997 17:46:18
>Number:         3622
>Category:       port-amiga
>Synopsis:       /src/sys/adosfs/advnops.c contains a typo
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    gnats-admin (GNATS administrator)
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Wed May 14 09:05:10 1997
>Last-Modified:
>Originator:     Thorsten Frueauf
>Organization:
private
>Release:        <NetBSD-current source date> NetBSD current 13.05.1997
>Environment:
	
System: NetBSD di_frueauf 1.2D NetBSD 1.2D (CYBERDYNE) #0: Tue May 6 20:43:22 CEST 1997 milano@di_frueauf:/usr/src/sys/arch/amiga/compile/CYBERDYNE amiga


>Description:
	
/src/sys/adosfs/advnops.c contains a typo

>How-To-Repeat:
	
Try to make a recent kernel on amiga and watch:

cc  -Werror -Wall -Wstrict-prototypes -O2 -m68060 -Wa,-m68030 -msoft-float -I. -
I../../../../arch -I../../../.. -nostdinc -DSWAPPAGER -DVNODEPAGER -DDEVPAGER -D
EXEC_AOUT -DEXEC_SCRIPT -DRTC_OFFSET="0" -DNMBCLUSTERS="0x400" -DM68060 -DM060SP
 -DM68040 -DFPSP -DM68030 -DM68020 -DFPCOPROC -DINET -DGATEWAY -DDIRECTED_BROADC
AST -DMROUTING -DFFS -DMFS -DNFS -DADOSFS -DCD9660 -DMSDOSFS -DFDESC -DKERNFS -D
NULLFS -DPROCFS -DUMAPFS -DUNION -DNFSSERVER -DFIFO -DQUOTA -DCOMPAT_12 -DCOMPAT
_10 -DCOMPAT_09 -DCOMPAT_43 -DCOMPAT_SUNOS -DTCP_COMPAT_42 -DCOMPAT_NOMID -DSYSV
SHM -DSYSVMSG -DSYSVSEM -DUCONSOLE -DLKM -DNKMEMCLUSTERS=256 -DKTRACE -DMACHINE_
NONCONTIG -DKBDRESET -DSERIBUF_SIZE=4096 -DSEROBUF_SIZE=32 -DLEV6_DEFER -DCL5426
CONSOLE -DMAXUSERS=16 -D_KERNEL  -Dmc68020 -Damiga  -c ../../../../adosfs/advnop
s.c
../../../../adosfs/advnops.c: In function `adosfs_access':
../../../../adosfs/advnops.c:855: `vp' undeclared (first use this function)
../../../../adosfs/advnops.c:855: (Each undeclared identifier is reported only o
nce
../../../../adosfs/advnops.c:855: for each function it appears in.)
*** Error code 1

>Fix:
	
Dunno if this is the real patch, but the following worked for me:

*** advnops.c-orig	Mon May 12 16:45:18 1997
--- advnops.c	Wed May 14 17:20:43 1997
***************
*** 852,858 ****
  #endif
  #ifdef QUOTA
  #endif
! 	error = vaccess(vp->v_type, adunixprot(ap->adprot) & ap->amp->mask,
  	    ap->uid, ap->gid, sp->a_mode, sp->a_cred);
  #ifdef ADOSFS_DIAGNOSTIC
  	printf(" %d)", error);
--- 852,858 ----
  #endif
  #ifdef QUOTA
  #endif
! 	error = vaccess(sp->a_vp->v_type, adunixprot(ap->adprot) & ap->amp->mask,
  	    ap->uid, ap->gid, sp->a_mode, sp->a_cred);
  #ifdef ADOSFS_DIAGNOSTIC
  	printf(" %d)", error);
>Audit-Trail:
>Unformatted:
/src/sys/adosfs/advnops.c contains a typo