Subject: Re: bin/3603: pppd is installed in /.
To: None <netbsd-bugs@NetBSD.ORG>
From: Simon Burge <simonb@telstra.com.au>
List: netbsd-bugs
Date: 05/11/1997 12:51:52
On Sun, 11 May 1997 08:33:24 +0900 (JST)  enami@ba2.so-net.or.jp wrote:

> 
> >Number:         3603
> 
> >Fix:
> 	There seems at least 3 ways to fix this:
> 
> 	1) Define BINDIR as /usr/sbin in pppd/pppd/Makefile (like
> 	pppd/chat, pppd/pppstats and sendmail/src).
> 
> 	2) Include ../../Makefile.inc in pppd/pppd/Makefile to import
> 	definition of BINDIR (like amd, lpd, named, and timed).
> 
> 	3) Create pppd/Makefile.inc and include ../../Makefile.inc
> 	(like dhcp and ipf) or define BINDIR (like gspa, mopd, xntp
> 	and ypserv).

And Christos commited fix #2 to fix this.  Obviously the intent is to
read something out of the parent directory of the package - it's just
the nested directories in some packages that causes problems.

Since this seems to be a commonish problem (6 or 7 examples above),
would be it be easier to change the bsd.*.mk files to do something like:

.if exists(${.CURDIR}/../Makefile.inc)
.include "${.CURDIR}/../Makefile.inc"
.elif exists(${.CURDIR}/../../Makefile.inc)
.include "${.CURDIR}/../../Makefile.inc"
.endif

A quick scan of the source tree showed no need to look for
../../../Makefile.inc .

Just an idea...

 Simon.
--
Simon Burge						simonb@telstra.com.au
UNIX Support, CPR Project.				+61 3 9634 3974 (Phone)
Telstra Corporation, Melbourne, Australia.		+61 3 9670 1189 (Fax)