Subject: port-hp300/3565: hp300/pmap.c defines "firstpage" which gets not always used
To: None <gnats-bugs@gnats.netbsd.org>
From: None <frueauf@ira.uka.de>
List: netbsd-bugs
Date: 05/01/1997 13:49:32
>Number:         3565
>Category:       port-hp300
>Synopsis:       hp300/pmap.c defines "firstpage" which gets not always used
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    gnats-admin (GNATS administrator)
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu May  1 05:05:01 1997
>Last-Modified:
>Originator:     Thorsten Frueauf
>Organization:
private
	
>Release:        <NetBSD-current source date> NetBSD current 30.04.1997
>Environment:
	
HP 9000/400T, only "options HP400" enabled.

>Description:
	
If you compile a kernel on a HP 9000/400T with current source tree,
compilation stops at /src/sys/arch/hp300/hp300/pmap.c with a warning
(thus compilation stops because of -Werror):

In line 842 of pmap.c there is the declaration of "boolean_t firstpage" -
but the use of this variable is in an "#ifdef M68K_MMU_HP" context.
I don't know when M68K_MMU_HP is defined - my kernel file did not -
so the compiler complains about unused variable.

>How-To-Repeat:
	
Compile a recent kernel on hp300 where M68K_MMU_HP is not defined.

>Fix:
	
For me, the problem went away deleting the declaration. For a proper fix, I 
would suggest to encapsulate the declaration with #ifdef M68K_MMU_HP" too.
At least the resulting kernel worked for me on my machine.
>Audit-Trail:
>Unformatted:
hp300/pmap.c defines "firstpage" which gets not always used