>Number:         3426
>Category:       kern
>Synopsis:       Kernel does not compile with ipfilter
>Confidential:   no
>Severity:       critical
>Priority:       high
>Responsible:    kern-bug-people (Kernel Bug People)
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Mar 31 15:35:01 1997
>Last-Modified:
>Originator:     Lennart Augustsson
>Organization:
Department of Computing Science, Chalmers University
>Release:        NetBSD-curent 97-03-30
>Environment:
System: NetBSD calvin 1.2D NetBSD 1.2D (CALVIN) #151: Mon Mar 31 16:50:00 MEST 1997 augustss@calvin:/usr/src/sys/arch/i386/compile/CALVIN i386


>Description:
	The kernel does not compile with
	    pseudo-device   ipfilter
	after the new version of the IP filter package was installed.

	I also have my doubts that NAT really works, but I have
	no hard evidence.
>How-To-Repeat:
	Just use ipfilter, config, and make.
>Fix:
	Remove a cast to void.  KFREE expands to a statement rather
	than an expression.

*** /users/NetBSD/src/sys/netinet/ip_fil.c      Mon Mar 31 15:22:27 1997
--- /sys/netinet/ip_fil.c       Tue Apr  1 01:17:13 1997
***************
*** 546,552 ****
                        error = ESRCH;
                else {
                        *ftail = f->fr_next;
!                       (void) KFREE(f);
                }
        } else {
                if (f)
--- 546,552 ----
                        error = ESRCH;
                else {
                        *ftail = f->fr_next;
!                       KFREE(f);
                }
        } else {
                if (f)
>Audit-Trail:
>Unformatted: