Subject: kern/3282: unused global variable scsi_sense in sd.c
To: None <gnats-bugs@gnats.netbsd.org>
From: None <enami@ba2.so-net.or.jp>
List: netbsd-bugs
Date: 03/03/1997 22:22:27
>Number: 3282
>Category: kern
>Synopsis: unused global variable scsi_sense in sd.c
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: kern-bug-people (Kernel Bug People)
>State: open
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Mon Mar 3 06:20:03 1997
>Last-Modified:
>Originator: enami tsugutomo
>Organization:
An individual
>Release: NetBSD-current 1997 Mar 01
>Environment:
System: NetBSD pavlov.enami.ba2.so-net.or.jp 1.2C NetBSD 1.2C (PAVLOV) #164: Sat Feb 8 01:00:12 JST 1997 enami@pavlov.enami.ba2.so-net.or.jp:/b/netbsd/kernel/compile/PAVLOV i386
>Description:
There is an unused global variable `scsi_sense' in sd.c. It
not seems to be used in anywhere. Probably it is leftover
when moving struct scsi_mode_sense_data from function local
scope to file scope.
>How-To-Repeat:
Read the source. It is the only way to find it.
>Fix:
Here is a patch.
Index: sd.c
===================================================================
RCS file: /a/cvsroot/NetBSD/src/sys/scsi/sd.c,v
retrieving revision 1.1.1.6
diff -c -r1.1.1.6 sd.c
*** sd.c 1997/02/22 13:23:17 1.1.1.6
--- sd.c 1997/03/03 13:16:40
***************
*** 102,108 ****
struct scsi_mode_header header;
struct scsi_blk_desc blk_desc;
union disk_pages pages;
! } scsi_sense;
#ifdef __BROKEN_INDIRECT_CONFIG
int sdmatch __P((struct device *, void *, void *));
--- 102,108 ----
struct scsi_mode_header header;
struct scsi_blk_desc blk_desc;
union disk_pages pages;
! };
#ifdef __BROKEN_INDIRECT_CONFIG
int sdmatch __P((struct device *, void *, void *));
>Audit-Trail:
>Unformatted: