>Number:         2850
>Category:       port-i386
>Synopsis:       apm.c doesn't compile
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    gnats-admin (GNATS administrator)
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Oct 15 19:05:00 1996
>Last-Modified:
>Originator:     Dave Huang
>Organization:
Name: Dave Huang     |   Mammal, mammal / their names are called /
INet: khym@bga.com   |   they raise a paw / the bat, the cat /
FurryMUCK: Dahan     |   dolphin and dog / koala bear and hog -- TMBG
Dahan: Hani G Y+C 20 Y++ L+++ W- C++ T++ A+ E+ S++ V++ F- Q+++ P+ B+ PA+ PL++
>Release:        October 15, 1996
>Environment:
	
System: NetBSD apm2-120.realtime.net 1.2A NetBSD 1.2A (SPIFF) #49: Tue Oct 15 20:23:54 CDT 1996 khym@apm2-107.realtime.net:/usr/src/sys/arch/i386/compile/SPIFF i386


>Description:
A kernel configured with APM support failes to compile with the
following error:

../../../../arch/i386/i386/apm.c:131: syntax error before `__printf_attribute__'
*** Error code 1

Stop.

>How-To-Repeat:
Config a kernel with:
apm0    at mainbus0                     # Advanced power management

and try to compile it.

>Fix:
--- /usr/src/sys/arch/i386/i386/apm.c	Mon Oct 14 11:07:40 1996
+++ apm.c	Tue Oct 15 02:30:43 1996
@@ -128,7 +128,7 @@
 STATIC void apm_disconnect __P((void *));
 #endif
 STATIC void apm_perror __P((const char *, struct apmregs *, ...))
-	    __printf_attribute__((__format__(__printf__,1,3)));
+	    __attribute__((__format__(__printf__,1,3)));
 #if 0
 STATIC void apm_powmgt_enable __P((int));
 #endif


Or perhaps it should be __kprintf_attribute__ ?
>Audit-Trail:
>Unformatted: