Subject: kern/2555: DEFPA card probe/match fails - too many return 0's
To: None <gnats-bugs@NetBSD.ORG>
From: Peter Galbavy <peter@peter.noc.demon.net>
List: netbsd-bugs
Date: 06/17/1996 11:18:26
>Number: 2555
>Category: kern
>Synopsis: if_pci.c has typo and always returns 0 for probe
>Confidential: yes
>Severity: serious
>Priority: high
>Responsible: kern-bug-people (Kernel Bug People)
>State: open
>Class: sw-bug
>Submitter-Id: net
>Arrival-Date: Mon Jun 17 05:50:02 1996
>Last-Modified:
>Originator: Peter Galbavy
>Organization:
Demon Internet
>Release: 1.2_ALPHA
>Environment:
Pentium, DEFPA and -current
System: NetBSD peter.noc.demon.net 1.2_ALPHA NetBSD 1.2_ALPHA (ALPHA) #0: Fri Jun 7 12:08:14 BST 1996 peter@peter.noc.demon.net:/sys/arch/alpha/compile/ALPHA alpha
>Description:
build a kernel with fpa* in the config and a DEFPA card in - watch it
failt to probe for the device.
>How-To-Repeat:
Easy
>Fix:
*** /tmp/if_fpa.c Mon Jun 17 11:17:21 1996
--- /tmp/if_fpa.c.new Mon Jun 17 11:16:54 1996
***************
*** 372,378 ****
if (PCI_PRODUCT(pa->pa_id) != PCI_PRODUCT_DEC_DEFPA)
return 0;
! return 0;
}
static void
--- 372,378 ----
if (PCI_PRODUCT(pa->pa_id) != PCI_PRODUCT_DEC_DEFPA)
return 0;
! return 1;
}
static void
>Audit-Trail:
>Unformatted: