Subject: bin/2449: Typo (= instead of ==) prevents kerberos login from working
To: None <gnats-bugs@NetBSD.ORG>
From: None <abrown@eecs.harvard.edu>
List: netbsd-bugs
Date: 05/21/1996 10:32:55
>Number:         2449
>Category:       bin
>Synopsis:       Typo (= instead of ==) prevents kerberos login from working
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    bin-bug-people (Utility Bug People)
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue May 21 11:05:01 1996
>Last-Modified:
>Originator:     Aaron Brown
>Organization:
Harvard University Computer Science Department
>Release:        20 May 1996
>Environment:
NetBSD/sparc SPARCstation-20 (not important)
System: NetBSD virtual4 1.1B NetBSD 1.1B (VIRTUAL4) #24: Fri May 3 23:08:57 EDT 1996 abrown@virtual4:/usr/src/sys/arch/sparc/compile/VIRTUAL4 sparc


>Description:
	/usr/bin/login when compiled with "KERBEROS=YES" fails to do correct
	kerberos authentication (it fails). This is due to a typo in a 
	comparison (= instead of ==). See below for patch.
>How-To-Repeat:
Install kerberized login. Try to login with kerberos password.
>Fix:
Index: klogin.c
===================================================================
RCS file: /a/cvsroot/src/usr.bin/login/klogin.c,v
retrieving revision 1.6
diff -c -r1.6 klogin.c
*** klogin.c	1995/03/08 19:41:36	1.6
--- klogin.c	1996/05/21 14:29:02
***************
*** 205,211 ****
  	}
  
  	/* undecipherable: probably didn't have a srvtab on the local host */
! 	if (kerror = RD_AP_UNDEC) {
  		syslog(LOG_NOTICE, "krb_rd_req: (%s)\n", krb_err_txt[kerror]);
  		dest_tkt();
  		return (1);
--- 205,211 ----
  	}
  
  	/* undecipherable: probably didn't have a srvtab on the local host */
! 	if (kerror == RD_AP_UNDEC) {
  		syslog(LOG_NOTICE, "krb_rd_req: (%s)\n", krb_err_txt[kerror]);
  		dest_tkt();
  		return (1);
>Audit-Trail:
>Unformatted: