Subject: port-sparc/2253: error in sparc/dev/esp.c
To: None <gnats-bugs@NetBSD.ORG>
From: Iain Hibbert <plunky@skate.demon.co.uk>
List: netbsd-bugs
Date: 03/24/1996 10:57:07
>Number:         2253
>Category:       port-sparc
>Synopsis:       error in sparc/dev/esp.c and it won't compile
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    gnats-admin (GNATS administrator)
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Mar 24 08:50:01 1996
>Last-Modified:
>Originator:     Iain Hibbert
>Organization:
	
>Release:        1.1
>Environment:
	
System: NetBSD skate.demon.co.uk 1.1 NetBSD 1.1 (skate) #0: Sun Dec 10 13:57:07 GMT 1995 plunky@skate.demon.co.uk:/home/plunky/src/sys/arch/sparc/compile/skate sparc


>Description:
trying to build a kernel, and it won't because in sparc/dev/esp.c (v1.43), on line 836
there is the following line..

                                printf("extcode: %x; ", xs->sense.extended_flags);

but there is no extended_flags part of the xs->sense structure.  I followed it through
(xs->sense is a scsi_sense_data structure, as defined in sys/scsi/scsi_all.h) to see
if it was a typo, but I can't work out what it really wants to print there..

also, this is within an #ifdef ESP_DEBUG statement, and ESP_DEBUG is defined in espvar.h
as 0 .. is this a mistake?  there are some tests to see if ESP_DEBUG > 0 and some
(including this one) to see if its defined at all - if I make it undefined, then
dma.c fails to compile, albeit with only an unused variable warning..

	
>How-To-Repeat:
	
>Fix:
	
I changed the #ifdef ESP_DEBUG on line 830 to #if ESP_DEBUG > 0 and it compiles
ok, though that hasn't fixed the real problem at all..
>Audit-Trail:
>Unformatted: