Subject: Re: port-i386/2184: i386 boot blocks don't compile
To: Gordon W. Ross <gwr@mc.com>
From: Scott Reynolds <scottr@plexus.com>
List: netbsd-bugs
Date: 03/07/1996 13:41:58
On Thu, 7 Mar 1996, Gordon W. Ross wrote:

> Hmmm...  I thought we had rules about what order kernel includes
> should be in, but I can't find them right now.

/usr/share/misc/style is what you wanted.

> Anyway, why not just put <sys/dirent.h> (and all other <sys/*.h>)
> before the files you reach over into ufs to get?

The problem that was reported is a valid one.  Some discussion has brought
to light the fact that the DIRSIZ macro was never intended to be anything
but ufs-specific.  I don't like this collision between the ufs DIRSIZ, the
compat (<dir.h>) DIRSIZ, and now the dirent DIRSIZ definitions.

I'd like to propose that the DIRSIZ macro be renamed in <sys/dirent.h>, 
in thise case, and change the two files that rely on this 
(msdosfs_vnops.c and cd9660_vnops.c) to use this new macro, instead.  I'd 
do it myself if I was clear on all of the ramifications...

--scott