>Number:         2108
>Category:       port-i386
>Synopsis:       some ISA drivers (sea, ie, mcd) spew too much
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    gnats-admin (GNATS administrator)
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Feb 22 03:35:02 1996
>Last-Modified:
>Originator:     Mike Long <mike.long@analog.com>
>Organization:
	Return Postage Guaranteed
>Release:        960221
>Environment:
System: NetBSD azathoth 1.1A NetBSD 1.1A (AZATHOTH) #15: Wed Feb 21 03:21:33 EST 1996 root@azathoth:/usr/src/sys/arch/i386/compile/AZATHOTH i386

>Description:
	Failed probes should not print anything, unless specifically
asked to do so (e.g., DEBUG kernel option).

>How-To-Repeat:
	Boot an INSTOTHER kernel on a PC that lacks any Seagate SCSI
adapters, AT&T Starlan cards, or Mitsumi CDROMs.  Potentially be
confused by messages that have no relevance to your hardware.

>Fix:
	seagate.c and if_ie.c use DIAGNOSTIC instead of a (possibly
device-specific) DEBUG option.  mcd.c has no excuse.  I used IEDEBUG
and MCDDEBUG in if_ie.c and mcd.c because they already existed.  I
used DEBUG in seagate.c because no seagate-specific option existed,
and DEBUG is already used elsewhere in the driver.

*** /sys/dev/isa/seagate.c~     Sun Dec 24 07:26:23 1995
--- /sys/dev/isa/seagate.c      Thu Feb 22 01:39:23 1996
***************
*** 379,385 ****
                break;
        default:
! #ifdef DIAGNOSTIC
!               printf("%s: board type unknown at address 0x%lx\n",
!                   sea->sc_dev.dv_xname, sea->maddr);
  #endif
                return 0;
--- 379,385 ----
                break;
        default:
! #ifdef DEBUG
!               printf("%s: board type unknown at address %#x\n",
!                   sea->sc_dev.dv_xname, ia->ia_maddr);
  #endif
                return 0;

*** /sys/dev/isa/if_ie.c~       Sun Dec 24 07:26:20 1995
--- /sys/dev/isa/if_ie.c        Thu Feb 22 01:35:58 1996
***************
*** 402,406 ****
        default:
                /* Anything else is not recognized or cannot be used. */
! #ifdef DIAGNOSTIC
                printf("%s: unknown AT&T board type code %d\n",
                    sc->sc_dev.dv_xname, SL_BOARD(c));
--- 402,406 ----
        default:
                /* Anything else is not recognized or cannot be used. */
! #ifdef IEDEBUG
                printf("%s: unknown AT&T board type code %d\n",
                    sc->sc_dev.dv_xname, SL_BOARD(c));

*** /sys/dev/isa/mcd.c~ Thu Feb  1 07:25:50 1996
--- /sys/dev/isa/mcd.c  Thu Feb 22 01:34:07 1996
***************
*** 798,804 ****
--- 798,806 ----
                break;
        default:
+ #ifdef MCDDEBUG
                printf("%s: unrecognized drive version %c%02x; will try to use it anyway\n",
                    sc->sc_dev.dv_xname,
                    mbx.res.data.continfo.code, mbx.res.data.continfo.version);
+ #endif
                sc->type = 0;
                break;

>Audit-Trail:
>Unformatted: