Subject: kern/2036: unp_detach gets declared at /src/sys/sys/un.h and
To: None <gnats-bugs@NetBSD.ORG>
From: Thorsten Frueauf <frueauf@ira.uka.de>
List: netbsd-bugs
Date: 02/06/1996 13:05:03
>Number:         2036
>Category:       kern
>Synopsis:       unp_detach gets declared at /src/sys/sys/un.h and 
         /src/sys/kern/uipc_usrreq.c
>Confidential:   no
>Severity:       serious
>Priority:       high
>Responsible:    kern-bug-people (Kernel Bug People)
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Feb  6 08:20:04 1996
>Last-Modified:
>Originator:     Thorsten Frueauf
>Organization:
private
>Release:        <NetBSD-current source date> NetBSD current 05.02.1996
>Environment:
	
System: NetBSD di_frueauf 1.1A NetBSD 1.1A (Milano) #1: Sat Feb 3 17:17:07 GMT 1996 milano@di_frueauf:/home/milano/source/netbsd-src/sys/arch/amiga/compile/Milano amiga


>Description:
	
`unp_detach' gets declared in /src/sys/sys/un.h and /src/sys/kern/uipc_urreq.c
which breaks the compilation of the new kernal.
>How-To-Repeat:
	
Try to compile a kernel with current 05.02.1996 source ans watch:

cc  -O2 -Werror -msoft-float -I. -I../../../../arch -I../../../.. -DMILANO -DHP3
80 -DHP375 -DHP370 -DHP360 -DHP350 -DHP340 -DHP330 -DHP320 -DGENERIC -DDIAGNOSTI
C -DDEBUG -DDDB -DCOMPAT_HPUX -DCOMPAT_NOLABEL -DUSELEDS -DFPSP -DTCP_COMPAT_42
-DMROUTING -DGATEWAY -DINET -DMFS -DPROCFS -DFDESC -DKERNFS -DUNION -DNFSCLIENT
-DNFSSERVER -DCD9660 -DQUOTA -DFFS -DFIFO -DNKMEMCLUSTERS=1024 -DKTRACE -DSYSVMS
G -DSYSVSEM -DSYSVSHM -DCOMPAT_10 -DCOMPAT_09 -DCOMPAT_44 -DCOMPAT_43 -DDEVPAGER
 -DVNODEPAGER -DSWAPPAGER -D_KERNEL -Dmc68020 -Dhp300 -DFPCOPROC  -c ../../../..
/kern/uipc_usrreq.c
../../../../kern/uipc_usrreq.c:355: conflicting types for `unp_detach'
../../../../sys/un.h:55: previous declaration of `unp_detach'
*** Error code 1

Stop.

>Fix:
	
I don't know the proper fix, I just removed the the declaration at
/src/sys/sys/un.h:

*** un.h-orig   Mon Feb  5 17:28:09 1996
--- un.h        Tue Feb  6 13:04:21 1996
***************
*** 52,58 ****
  int   unp_bind __P((struct unpcb *unp, struct mbuf *nam, struct proc *p));
  int   unp_connect __P((struct socket *so, struct mbuf *nam, struct proc *p));
  int   unp_connect2 __P((struct socket *so, struct socket *so2));
- void  unp_detach __P((struct unpcb *unp));
  void  unp_discard __P((struct file *fp));
  void  unp_disconnect __P((struct unpcb *unp));
  void  unp_drop __P((struct unpcb *unp, int errno));
--- 52,57 ----
>Audit-Trail:
>Unformatted:
unp_detach gets declared at /src/sys/sys/un.h and /src/sys/kern/uipc_urreq.c