Subject: port-amiga/1837: missing if_le changes for the amiga port
To: None <gnats-bugs@gnats.netbsd.org>
From: Bernd Ernesti <bernd@arresum.inka.de>
List: netbsd-bugs
Date: 12/14/1995 13:17:05
>Number:         1837
>Category:       port-amiga
>Synopsis:       missing if_le changes for the amiga port
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    gnats-admin (GNATS administrator)
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Dec 14 07:35:01 1995
>Last-Modified:
>Originator:     Bernd Ernesti
>Organization:
	
>Release:        NetBSD-current 12-Dec-95
>Environment:
	
System: NetBSD arresum 1.1 NetBSD 1.1 (VEEGO) #37: Sun Dec 10 01:43:36 MET 1995 bernd@arresum:/src/sys/arch/amiga/compile/VEEGO amiga


>Description:
	There are some recent changes to sys/dev/ic/am7990.c which breaks
	the amiga port
>How-To-Repeat:
	make an new kernel with if_le and see this:

../../../../arch/amiga/dev/if_le.c: In function `leattach':
../../../../arch/amiga/dev/if_le.c:138: `copytobuf_contig' undeclared (first use this function)
../../../../arch/amiga/dev/if_le.c:138: (Each undeclared identifier is reported only once
../../../../arch/amiga/dev/if_le.c:138: for each function it appears in.)
../../../../arch/amiga/dev/if_le.c:139: `copyfrombuf_contig' undeclared (first use this function)
../../../../arch/amiga/dev/if_le.c:142: `zerobuf_contig' undeclared (first use this function)
../../../../arch/amiga/dev/if_le.c: At top level:
../../../../arch/amiga/dev/if_le.c:194: `copytobuf_contig' used prior to declaration
../../../../arch/amiga/dev/if_le.c:208: `copyfrombuf_contig' used prior to declaration
../../../../arch/amiga/dev/if_le.c:222: `zerobuf_contig' used prior to declaration
*** Error code 1 (continuing)

>Fix:

Apply this diff.

*** src/sys/arch/amiga/dev/if_le.c-orig	Sat Oct 14 02:43:01 1995
--- src/sys/arch/amiga/dev/if_le.c	Thu Dec 14 13:08:28 1995
***************
*** 63,68 ****
--- 63,69 ----
  #include <amiga/dev/zbusvar.h>
  #include <amiga/dev/if_levar.h>
  #include <dev/ic/am7990reg.h>
+ #define LE_NEED_BUF_CONTIG
  #include <dev/ic/am7990var.h>
  
  /* offsets for:	   ID,   REGS,    MEM */
***************
*** 183,233 ****
  	sc->sc_isr.isr_arg = sc;
  	sc->sc_isr.isr_ipl = 2;
  	add_isr(&sc->sc_isr);
- }
- 
- /*
-  * Routines for accessing the transmit and receive buffers.
-  */
- 
- void
- copytobuf_contig(sc, from, boff, len)
- 	struct le_softc *sc;
- 	caddr_t from;
- 	int boff, len;
- {
- 	volatile caddr_t buf = sc->sc_mem;
- 
- 	/*
- 	 * Just call bcopy() to do the work.
- 	 */
- 	bcopy(from, buf + boff, len);
- }
- 
- void
- copyfrombuf_contig(sc, to, boff, len)
- 	struct le_softc *sc;
- 	caddr_t to;
- 	int boff, len;
- {
- 	volatile caddr_t buf = sc->sc_mem;
- 
- 	/*
- 	 * Just call bcopy() to do the work.
- 	 */
- 	bcopy(buf + boff, to, len);
- }
- 
- void
- zerobuf_contig(sc, boff, len)
- 	struct le_softc *sc;
- 	int boff, len;
- {
- 	volatile caddr_t buf = sc->sc_mem;
- 
- 	/*
- 	 * Just call bzero() to do the work.
- 	 */
- 	bzero(buf + boff, len);
  }
  
  #include <dev/ic/am7990.c>
--- 184,189 ----

>Audit-Trail:
>Unformatted: