Subject: Re: lib/1764: __ivaliduser() contains call to abort()
To: None <netbsd-bugs@NetBSD.ORG>
From: Christos Zoulas <email@example.com>
Date: 11/16/1995 21:19:36
In article <199511161232.HAA17255@pattern.arlington.ma.us> firstname.lastname@example.org (John Kohl) writes:
>Actually, there are other stylistic no-nos in rcmd.c (assuming boolean
>value of a == b is either 0 or 1)
This is not a stylistic nono. K&R 2 specifies that. The only compiler
that used to return -1 for TRUE [I am showing my age again, I should
stop bringing up historical facts] was an early version of a compiler
for the Macs that shall remain unnamed.
There is more code in the kernel that uses my pet peeve stylistic nono:
value = !! expression;
value = expression != 0;
I hate to have to always have think about the double negation, but
then I might be just dumb.