Subject: Re: port-i386/1179: wss driver improvements
To: None <mycroft@ai.mit.edu>
From: Mike Long <mike.long@analog.com>
List: netbsd-bugs
Date: 07/05/1995 02:17:16
>Date: Sun, 2 Jul 1995 22:16:19 -0400
>From: "Charles M. Hannum" <mycroft@ai.mit.edu>
>
>
>		*/
>   -           sc->chip_name = "cs4231";
>   +           if ((tmp1 & 0x0f) == 0x8a) {			<-----
>   +               tmp1 = ad_read(sc, SP_VERSION_ID);
>   +               sc->rev |= (tmp1 & 0xe7);
>
>That looks wrong.

You're right, that line should be:

if ((tmp1 & 0x8f) == 0x8a) {

(Actually, I should be using ID_MASK from ad1848reg.h, but first I
need to decide wheter I should make all of the _MASK defs from
ad1848reg.h positive masks or negative ones....)
-- 
Mike Long <mike.long@analog.com>           http://www.shore.net/~mikel
VLSI Design Engineer         finger mikel@shore.net for PGP public key
Analog Devices, CPD Division          CCBF225E7D3F7ECB2C8F7ABB15D9BE7B
Norwood, MA 02062 USA                assert(*this!=opinionof(Analog));