Subject: Re: port-hp300/609: hp300 ethernet driver too noisy
To: Jason R. Thorpe <email@example.com>
From: Chris G Demetriou <Chris_G_Demetriou@LAGAVULIN.PDL.CS.CMU.EDU>
Date: 12/03/1994 22:43:12
> Apply the following patch to .../hp300/dev/if_le.c. It wraps the
> offending printf's in #ifdef DIAGNOSTIC...
i think a better fix might be:
(1) add error counters for those types of errors (so that
the admin could find out how many of them there were
if they _really_ wanted to know), and
(2) make the printf #ifdef LEDEBUG and dependent on
the only problem with that is that they're not really 'debugging'
messages, but neither do i think they should always be printed if
DIAGNOSTIC is defined. (I also think that the counts should probably
be kept in any case...)