Subject: Re: Cosmetic issue during probe of acpitz
To: Paul Goyette <paul@whooppee.com>
From: Jared D. McNeill <jmcneill@invisible.ca>
List: current-users
Date: 12/07/2007 14:09:36
On Fri, 7 Dec 2007, Paul Goyette wrote:
> Note that the 'unable to get polling interval' line is printed in the middle 
> of the expected probe line.  Not a big deal.  I can work on a fix if anyone 
> else thinks it's worthwhile, or I can live with it the way it is.

Please try the following patch.

Cheers,
Jared

Index: acpi_tz.c
===================================================================
RCS file: /cvsroot/src/sys/dev/acpi/acpi_tz.c,v
retrieving revision 1.29
diff -u -r1.29 acpi_tz.c
--- acpi_tz.c	2 Dec 2007 06:26:40 -0000	1.29
+++ acpi_tz.c	7 Dec 2007 19:08:55 -0000
@@ -169,15 +169,13 @@
  	aprint_naive("\n");

  	rv = acpi_eval_integer(sc->sc_devnode->ad_handle, "_TZP", &v);
-	if (ACPI_FAILURE(rv)) {
-		aprint_verbose("%s: unable to get polling interval; using default of",
-		    sc->sc_dev.dv_xname);
+	if (ACPI_FAILURE(rv))
  		sc->sc_zone.tzp = ATZ_TZP_RATE;
-	} else {
+	else
  		sc->sc_zone.tzp = v;
-		aprint_verbose("%s: polling interval is", sc->sc_dev.dv_xname);
-	}
-	aprint_verbose(" %d.%ds\n", sc->sc_zone.tzp / 10, sc->sc_zone.tzp % 10);
+
+	aprint_debug(" sample rate %d.%ds\n",
+	    sc->sc_zone.tzp / 10, sc->sc_zone.tzp % 10);

  	/* XXX a value of 0 means "polling is not necessary" */
  	if (sc->sc_zone.tzp == 0)