Subject: Re: ACPI address32 resource support
To: Quentin Garnier <firstname.lastname@example.org>
From: Nicolas Joly <email@example.com>
Date: 09/28/2007 17:22:03
On Mon, Sep 24, 2007 at 12:44:06PM +0200, Quentin Garnier wrote:
> On Mon, Sep 24, 2007 at 12:17:13PM +0200, Nicolas Joly wrote:
> > The attached patch fix it by addind ACPI address32 resource support
> > (fixed size only).
> > hpet0 at acpi0 (HPET, PNP0103-0)
> > hpet0: mem 0xfed00000-0xfed003ff
> > hpet0: Found 64-bits HPET, will only use lowest 32-bits
> > timecounter: Timecounter "hpet0" frequency 14318179 Hz quality 2000
> > I'd like to to commit it, but want some review from an ACPI guru
> > before.
> It's mostly fine. I'd add a check that the device is a consumer of the
> resource, and looking at FreeBSD's code, they also check the length is
> not zero. Apart from that it's mostly identical.
Applied with suggested change. Thanks.
Biological Software and Databanks.
Institut Pasteur, Paris.