--3VH1SAMC12vKu3aE
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, Aug 17, 2007 at 01:51:17PM +0200, Juan RP wrote:
>=20
> Hi,
>=20
> I added support for the TCO (watchdog) on ICH6 or newer chipsets,
> adapter from FreeBSD and verified with the datasheet.
>=20
> I tested it with ICH7 and works fine (you can test it by adding
> a timeout of X seconds and skipping the bus_space_write_X() in
> tcotimer_tickle() to the TCO_RLD register).
>=20
> I'm interested in reports about this working on ICH5 or older.
> Please test and let me know if there's some problem, I'll commit
> it in 1st September if there are no complaints or other problems.
>=20
> http://www.netbsd.org/~xtraeme/tco_ich6plus.diff

As a general rule, don't hold resources for longer than necessary, i.e.
free them as soon as you know you won't use them.

So please unmap the regions you won't be using anymore, either because
there is an error or because you're done with them.  Along those lines,
don't keep stuff in the softc you won't actually be using outside of
initialisation.

--=20
Quentin Garnier - cube@cubidou.net - cube@NetBSD.org
"You could have made it, spitting out benchmarks
Owe it to yourself not to fail"
Amplifico, Spitting Out Benchmarks, Hometakes Vol. 2, 2005.

--3VH1SAMC12vKu3aE
Content-Type: application/pgp-signature
Content-Disposition: inline

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (NetBSD)

iQEVAwUBRsW4xtgoQloHrPnoAQLDNgf/V6SoUgKs3UgpAvnrl/1V17PyzKW9b/GO
w3BT+ddPVk88+Yoq3Qzk/5iV248doL3+EJl5I7E239aM7q7YVxU348+KCH+uvUsH
6KyN2urnT9t/iWNQPxsPTgF0ZMQeJo5iQMy5du0ObYh1hmlcvC1DRyTpH6i+v1yo
z2lRrwDu6qBaiJhx+BI/ZW7dhSUq0mn5u2qVKJwaiLZIsLv0igNb+T9GCrv0JjRs
vhy+vg9eMa0F6+HvArt/6GyVk0AZsiKnhxfdc0R+tIIXxDct6cywokXP9jP3nFX1
3CLnnH/55OZ8ZiUtzHiJ76Z0r5yCvSfQHnVwnWBvBhczeiED44neLg==
=GnWM
-----END PGP SIGNATURE-----

--3VH1SAMC12vKu3aE--