Subject: Re: Recording with wss(4) hardware seems to be broken in NetBSD-3.X, anyone else agree?
To: None <current-users@NetBSD.org, port-i386@NetBSD.org>
From: Eric Haszlakiewicz <erh@nimenees.com>
List: current-users
Date: 08/14/2007 14:50:09
On Mon, Aug 13, 2007 at 08:06:49PM +0400, Valeriy E. Ushakov wrote:
> PS: And since I'm the style rant mood - I prefer prefix notation for
> that, since I hate to hunt down for that increment hidden near the
> right margin in something like
>
> m->m_pkthdr.csum_flags = (CSUM_IP_CHECKED|CSUM_IP_VALID);
> rspq_to_qset(rq)->port_stats[SGE_PSTAT_RX_CSUM_GOOD]++;
> m->m_pkthdr.csum_flags = (CSUM_IP_CHECKED|CSUM_IP_VALID|CSUM_DATA_VALID|CSUM_PSEUDO_HDR);
well, to each his own I guess, but I prefer to see the ++ closer to
what is actually being incremented. Also, the postfix notation seems to be
used so much more often that whenever I see the prefix notation I wonder
if someone is trying to do something "clever".
eric